Add CONTRIBUTING.md -Scaffold #3

blaggacao · 2014-05-24T22:22:33Z

This is a copy of ansibles CONTRIBUTING.md adapted to ODOO, it is quite clear and friendly and helps get your way arround. As my knowledge is limited, I could not redact every secction. Thos secction who aren't yet redacted are idented as code blocks for convenience to the revisor.

odoo#61 will be solved by this.

This is a copy of ansibles CONTRIBUTING.md adapted to ODOO, it is quite clear and friendly and helps get your way arround. As my knowledge is limited, I could not redact every secction. Thos secction who aren't yet redacted are idented as `code blocks` for convenience to the revisor. [This Issue](odoo#61) will be solved by this.

blaggacao · 2014-05-24T22:31:46Z

sry, wrong odoo repository

blaggacao · 2014-05-24T22:33:18Z

I cannot fork from the odoo/odoo
It autmatically forks from dev-odoo/odoo
so this is why this is here... Not my fault.

xmo-odoo · 2014-05-25T08:27:57Z

I cannot fork from the odoo/odoo

you can (by deleting your existing fork and creating a new one from the original repository)
that's not even relevant, you can edit the destination repository while creating the PR, you're not bound to the one you originally forked

blaggacao · 2014-05-25T15:48:55Z

Thanks! Will do that :-)

…ner-dev-moylop260-2 [8.0][REF] hr_payroll_account: Add fields.function partner_id to hr.payslip.line

When opening a view in a dialog, the favorite filters were not loaded. For example on the runbot: 1. In CRM, open any lead, edit it, and open the Customer dropdown 2. Create a custom filter, save it as favorite, and close the dialog 3. Open the dialog again: you don't see your new filter With this commit, you will see your filter at step #3

Before this commit Bold shape 10 & 11 had no transparent color After this commit Bold shape 10 & 11 have a transparent color instead of their former color #3 (#F6F6F6) task-2357174 odoo#59613

Before this commit Bold shape 10 & 11 had no transparent color After this commit Bold shape 10 & 11 have a transparent color instead of their former color #3 (#F6F6F6) task-2357174 odoo#59613 X-original-commit: 71b3b2d

Before this commit Bold shape 10 & 11 had no transparent color After this commit Bold shape 10 & 11 have a transparent color instead of their former color #3 (#F6F6F6) task-2357174 odoo#59613

Before this commit Bold shape 10 & 11 had no transparent color After this commit Bold shape 10 & 11 have a transparent color instead of their former color #3 (#F6F6F6) task-2357174 odoo#59613 X-original-commit: 71b3b2d

# This is the 1st commit message: [IMP] Starting to rectify the front end # This is the commit message #2: [IMP] First modifications of eLearning # This is the commit message #3: [IMP] Did until the Certifications # This is the commit message #4: [IMP] Starting to rectify the front end

Issue #1: pasting image/video URL as link or text Before this commit, pasting an image or video url as simple text was failing, and pasting it as a link was undoing the last modification before it. This happens because Powerbox.preValidate() reverts one history step before calling the callback attached to the Powerbox command. When pasting the url as simple text, the result was deleting the already inserted text. In case of pasting the url as a link, the callback to this command already performs a historyUndo(), and reverting history one step further leads to loss of previous modifications. In order to skip the call to preValidate, this commit adds a "shouldPreValidate" method (returning "false") to the command passed to Powerbox.open(). Such mechanism was introduced by commit odoo@a9c363c. Issue #2: transforming image/video URL pasted as text with space After pasting a URL as text at the end of a line, there's no way to type more text in that line (separated from the link by a space) without transforming it into a link. This commit ensures a space is added after the URL if it is pasted as text before a line break (introduced by a BR or a block element). Issue #3: pasting image/video URL + other text fragments The powerbox commands are not compatible with an image/video URL + text or multiple URLs. Choosing one of its commands will lead to loss of all text fragments but the last valid URL. This commit ensures the powerbox options are only offered when a single image/video URL is pasted. Issue #4: pasting image URL inside an exisiting link Even though the Editor's specs do not allow a URL to be transformed into a link when pasting it inside an exisiting link, pasting an image URL inside a link would open the powerbox with 3 commands, one of them allowing to transform the URL into a link. This commit ensures the "Paste as URL" command is not present in the powerbox in such case. When pasting an image URL inside an "isolated" link (after having clicked on it and making it the only contenteditable in the document), the cursor disappeared, preventing the powerbox to open (it would open later when insering text somewhere outside the link). This commit fixes it by restoring the cursor position after pasting an image URL inside an isolated link. Issue #5: selection restore after pasting and UNDO After pasting a valid URL (not image or video) on a non-collapsed selection followed by UNDO, the selection was not restored to the original range. This was due to not recording the selection in the current history step before creating the link. This commit introduces a call to _recordHistorySelection() before creating a link. After pasting text composed of a valid URL between text fragments on a non-collapsed selection followed by UNDO, the selection was again not properly restored. This time, because each text fragment insertion was done via execCommand, which calls _computeHistorySelection and thus overwrites the current step's selection. This commits calls _applyCommand instead, which skips the computing of new selections and keeps the one done onSelectionChange. Issue #6: unnecessary regex matching Before this commit, every text fragment in "text URL text" was being prepended with "https://" and a match with the URL regex was attempted. Every fragment (text or URL) was also probed for a match with the youtube video URL regex, but such matches would be discarded anyway in apps where the allowCommandVideo option is set to false. This commit avoids unnecessary searching with regular expressions by treating pasting of a single URL (possibly an image or video URL that would lead to powerbox commands) differently than URLs pasted among other text fragments or other URLs (see issue #2 above). Issue #7: historyPauseSteps with argument This function takes no arguments. Yet, it was called with the string 'onPaste' as argument. This commit removes it. task-3099012

# This is the 1st commit message: fixup # This is the commit message #2: wip # This is the commit message #3: [FIX] account: add/rework tests of taxes update Adds more tests to the taxes update method. Rework of existing tests that created useless objects. # This is the commit message #4: [FIX] account: fix notification to account managers When upgrading taxes we send a message to accounting advisors if we duplicated a tax, so he can check if the initial tax is still relevant. The message was sent multiple time per advisor when there were multiple advisors. Related: odoo#109062 Related: odoo@7f62a1b#commitcomment-97941667

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. Task: 4387232

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. Task: 4387232 X-original-commit: 35abe58

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. closes odoo#189835 Task: 4387232 Related: odoo/enterprise#75261 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. Task: 4387232 X-original-commit: 35abe58

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. closes odoo#199514 Task: 4387232 X-original-commit: 35abe58 Related: odoo/enterprise#80313 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. closes odoo#199489 Task: 4387232 X-original-commit: 35abe58 Related: odoo/enterprise#80296 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. closes odoo#199506 Task: 4387232 X-original-commit: 35abe58 Related: odoo/enterprise#80305 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. closes odoo#189835 Task: 4387232 Related: odoo/enterprise#75261 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

blaggacao added 2 commits May 24, 2014 17:17

codeblocks added

4ece3eb

blaggacao closed this May 24, 2014

blaggacao reopened this May 24, 2014

xmo-odoo closed this May 25, 2014

blaggacao deleted the patch-3 branch May 26, 2014 15:08

apineux pushed a commit that referenced this pull request Feb 24, 2015

Merge pull request #3 from vauxoo-dev/8.0-hr-payroll-account-get-part…

e0907f8

…ner-dev-moylop260-2 [8.0][REF] hr_payroll_account: Add fields.function partner_id to hr.payslip.line

tbe-odoo added a commit that referenced this pull request Aug 10, 2017

[IMP] Analytic account: Fix reviews #3

412fb6c

tbe-odoo added a commit that referenced this pull request Nov 27, 2017

[IMP] Analytic account: Fix reviews #3

988bc68

rrahir added a commit that referenced this pull request Dec 17, 2024

[FIX] spreadheet_dashboard_website_sale: Fix sorted columns

3c80f19

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. Task: 4387232

rrahir added a commit that referenced this pull request Feb 26, 2025

[FIX] spreadheet_dashboard_website_sale: Fix sorted columns

8d9fcc9

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. Task: 4387232

fw-bot pushed a commit that referenced this pull request Feb 26, 2025

[FIX] spreadheet_dashboard_website_sale: Fix sorted columns

a92c505

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. Task: 4387232 X-original-commit: 35abe58

fw-bot pushed a commit that referenced this pull request Feb 26, 2025

[FIX] spreadheet_dashboard_website_sale: Fix sorted columns

2d7fb58

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. Task: 4387232 X-original-commit: 35abe58

fw-bot pushed a commit that referenced this pull request Feb 26, 2025

[FIX] spreadheet_dashboard_website_sale: Fix sorted columns

07e012c

Some pivots (#2 and #3) were in error because the field used to sort was not part of the measures. Task: 4387232 X-original-commit: 35abe58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add CONTRIBUTING.md -Scaffold #3

Add CONTRIBUTING.md -Scaffold #3

Uh oh!

blaggacao commented May 24, 2014

Uh oh!

blaggacao commented May 24, 2014

Uh oh!

blaggacao commented May 24, 2014

Uh oh!

xmo-odoo commented May 25, 2014

Uh oh!

blaggacao commented May 25, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add CONTRIBUTING.md -Scaffold #3

Add CONTRIBUTING.md -Scaffold #3

Uh oh!

Conversation

blaggacao commented May 24, 2014

Uh oh!

blaggacao commented May 24, 2014

Uh oh!

blaggacao commented May 24, 2014

Uh oh!

xmo-odoo commented May 25, 2014

Uh oh!

blaggacao commented May 25, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants