Skip to content

[IMP] phone: switch to current device + misc. ui changes#17724

Closed
huisit wants to merge 1 commit into
saas-19.3from
saas-19.3-phone-voip-switch-devices-rexhu
Closed

[IMP] phone: switch to current device + misc. ui changes#17724
huisit wants to merge 1 commit into
saas-19.3from
saas-19.3-phone-voip-switch-devices-rexhu

Conversation

@huisit
Copy link
Copy Markdown
Contributor

@huisit huisit commented May 6, 2026

documentation task card: https://www.odoo.com/odoo/project.task/6173615

key changes:

  • add move a call to another device section
  • update UI details to reflect current iteration

other changes:

  • restructured to consolidate information + simplify flow

notes:

  • this was originally meant to be a quick update for 19.3, but the UI details were pretty out of date.
  • will fix the hang up icon, pending antoine's review for niki's pr to add custom icon rotation angles.

This saas-19.3 PR can be FWP up to master.

@huisit huisit self-assigned this May 6, 2026
@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented May 6, 2026

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team May 6, 2026 00:16
@huisit huisit force-pushed the saas-19.3-phone-voip-switch-devices-rexhu branch from 5c7eec4 to 77a67a9 Compare May 6, 2026 00:19
@huisit huisit requested a review from jero-odoo May 7, 2026 19:03
@huisit huisit added the scope:phone phone app scope; originally "voip" label May 7, 2026
@huisit huisit requested review from larm-odoo and removed request for jero-odoo May 7, 2026 21:58
@huisit
Copy link
Copy Markdown
Contributor Author

huisit commented May 7, 2026

@larm-odoo this is ready for review, i'd particularly appreciate your feedback on a couple things!

  1. where to place the screenshot, if it's even necessary. i feel it would be helpful to provide at least one screenshot since the widget is distinct from the typical odoo ui, but it'll get out of date pretty quickly . do you think this would be a good compromise? i was also considering side-by-side images of each tab like a bootleg "gallery."
  2. the location of add and remove crm calls: this section doesn't fit neatly into the article. the plan is to leave it and relocate in the future when we create an article for the crm pipeline ui, i thought putting it as the last subsection under handle calls would be most discreet.

Copy link
Copy Markdown
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huisit - excellent doc! I do have a couple of ideas:
1 - The Troubleshooting section could be ONE section with no sub-sections, and you can make all the troubleshooting sub-sections CARDS! This way, the issue can be on the front of the card and you click for the info =) I think that would be super cool to add. As for the images- I'll be honest, I think you can get rid of ALL of them- none of them seem necessary.

As for the CRM placement, I have no issue with where it is, at the end of all the other actions. You COULD make a CRM section on its own, but honestly, it seems ok there.

Comment thread content/applications/productivity/phone/phone_widget.rst Outdated
Comment thread content/applications/productivity/phone/phone_widget.rst Outdated
Comment thread content/applications/productivity/phone/phone_widget.rst Outdated
Comment thread content/applications/productivity/phone/phone_widget.rst Outdated
@huisit huisit force-pushed the saas-19.3-phone-voip-switch-devices-rexhu branch from f30d683 to 628a1e3 Compare May 11, 2026 20:44
Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com>
@huisit huisit force-pushed the saas-19.3-phone-voip-switch-devices-rexhu branch from 628a1e3 to 3334767 Compare May 11, 2026 20:50
@huisit
Copy link
Copy Markdown
Contributor Author

huisit commented May 12, 2026

@larm-odoo I'm going hold off on the troubleshooting card formatting idea since most of it fits in the viewport -- you don't need to scroll much to view the entire section in this article -- but I'm going to see if I can implement it for a longer article like WhatsApp. Thank you for the review, especially catching the inverse icon!
@Felicious this is ready for final, here's the runbot article link!

@huisit huisit requested a review from Felicious May 12, 2026 00:45
Copy link
Copy Markdown
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work here, @huisit 😊

The article is SO well structured and so much easier to read compared to before! Each section is very logically titled, concise, and focused on the topic. You've really sectioned things out well based on concepts!

@robodoo r+

robodoo pushed a commit that referenced this pull request May 12, 2026
closes #17724

Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com>
@Felicious Felicious added 5 3 and removed 5 labels May 12, 2026
@Felicious
Copy link
Copy Markdown
Contributor

You forgot to add points 🫨 I assigned it 3 since it was a significant improvement for readability! I thought it made it quite close to the "50% of the doc changed" mark!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 scope:phone phone app scope; originally "voip"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants