[IMP] odoo_theme: add rotation classes#17827
Closed
nikibrown wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
nikibrown
requested review from
AntoineVDV,
huisit and
samueljlieber
and removed request for
samueljlieber
nikibrown
changed the title
nikibrown
changed the title
huisit
approved these changes
May 11, 2026
Contributor
huisit
left a comment
huisit
left a comment
There was a problem hiding this comment.
@nikibrown works like a charm! This is exactly what we need to replicate the in-product Hang Up button, and it'll be great to rotate icons ourselves instead of asking for help every time there's a custom rotation. Thanks for your help on this :)
AntoineVDV
reviewed
May 12, 2026
Collaborator
AntoineVDV
left a comment
AntoineVDV
left a comment
There was a problem hiding this comment.
Hi @nikibrown, you must check that all three CIs are green before marking the PR as ready for review. Then, reviewers will be automatically assigned depending on impacted files, without you needing to manually pick one.
nikibrown
force-pushed
the
19.0-phone-icon-rotate-nikbr
branch
from
9ae20c5 to
a7b604f
Compare
Contributor
Author
|
Thanks @AntoineVDV should be all set now. |
Contributor
Author
|
@AntoineVDV Can you take a look at this (or whoever is supposed to review?) We have another PR that needs to use some of these rotation classes to make the phone icons accurate. Thanks! |
edi-odoo
approved these changes
May 18, 2026
Contributor
edi-odoo
left a comment
edi-odoo
left a comment
There was a problem hiding this comment.
Great job, thanks! LGTM ;)
AntoineVDV
changed the title
Collaborator
|
@robodoo squash |
Collaborator
|
Merge method set to squash. |
This was referenced May 18, 2026
robodoo
pushed a commit
that referenced
this pull request
May 18, 2026
For 19.0 and up there is a need to adjust the rotation of the font awesome icons (specifically fa-phone) to match the ui in the Odoo phone app. Rather than creating a one off class for the phone icon, I used a sass loop to generate rotation classes in 5 degree increments so future icon adjustments can happen easily. Also removed some old CSS that was for internet explorer 9 with rotation issues. <img width="1705" height="1042" alt="image" src="https://github.com/user-attachments/assets/39b44197-177f-4874-92ad-c03a67b7e8f7" /> closes #17963 Forward-port-of: #17827 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Niki Brown (nikbr) <nikbr@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 18, 2026
For 19.0 and up there is a need to adjust the rotation of the font awesome icons (specifically fa-phone) to match the ui in the Odoo phone app. Rather than creating a one off class for the phone icon, I used a sass loop to generate rotation classes in 5 degree increments so future icon adjustments can happen easily. Also removed some old CSS that was for internet explorer 9 with rotation issues. <img width="1705" height="1042" alt="image" src="https://github.com/user-attachments/assets/39b44197-177f-4874-92ad-c03a67b7e8f7" /> closes #17968 Forward-port-of: #17827 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Niki Brown (nikbr) <nikbr@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 19, 2026
For 19.0 and up there is a need to adjust the rotation of the font awesome icons (specifically fa-phone) to match the ui in the Odoo phone app. Rather than creating a one off class for the phone icon, I used a sass loop to generate rotation classes in 5 degree increments so future icon adjustments can happen easily. Also removed some old CSS that was for internet explorer 9 with rotation issues. <img width="1705" height="1042" alt="image" src="https://github.com/user-attachments/assets/39b44197-177f-4874-92ad-c03a67b7e8f7" /> closes #17967 Forward-port-of: #17827 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Niki Brown (nikbr) <nikbr@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 19, 2026
For 19.0 and up there is a need to adjust the rotation of the font awesome icons (specifically fa-phone) to match the ui in the Odoo phone app. Rather than creating a one off class for the phone icon, I used a sass loop to generate rotation classes in 5 degree increments so future icon adjustments can happen easily. Also removed some old CSS that was for internet explorer 9 with rotation issues. <img width="1705" height="1042" alt="image" src="https://github.com/user-attachments/assets/39b44197-177f-4874-92ad-c03a67b7e8f7" /> closes #17970 Forward-port-of: #17827 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Niki Brown (nikbr) <nikbr@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For 19.0 and up there is a need to adjust the rotation of the font awesome icons (specifically fa-phone) to match the ui in the Odoo phone app.
Rather than creating a one off class for the phone icon, I used a sass loop to generate rotation classes in 5 degree increments so future icon adjustments can happen easily.
Also removed some old CSS that was for internet explorer 9 with rotation issues.