Skip to content

[ADD] accounting: document tax excl. / tax incl. toggle - #19634

Closed
dade-odoo wants to merge 1 commit into
saas-19.4from
saas-19.4-accounting-tax-incl-dade
Closed

[ADD] accounting: document tax excl. / tax incl. toggle#19634
dade-odoo wants to merge 1 commit into
saas-19.4from
saas-19.4-accounting-tax-incl-dade

Conversation

@dade-odoo

@dade-odoo dade-odoo commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

taskid-6344726

Adds an explanation of how the new Tax Excl. / Tax Incl. toggle on quotes/SOs/POs/invoices works.
Also adds more context to the tax computation page in general to make the page more clear.

@robodoo

robodoo commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Pull request status dashboard

@dade-odoo
dade-odoo force-pushed the saas-19.4-accounting-tax-incl-dade branch from 637253e to 71b2d57 Compare August 25, 2026 13:48
@dade-odoo
dade-odoo marked this pull request as ready for review August 26, 2026 09:31
@C3POdoo
C3POdoo requested a review from a team August 26, 2026 09:53
@dade-odoo
dade-odoo requested review from a team and removed request for a team August 26, 2026 10:08
@xpl-odoo
xpl-odoo requested review from xpl-odoo and removed request for a team September 1, 2026 07:09

@xpl-odoo xpl-odoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dade-odoo !
Already delegating, even though I got a suggestion for you regarding the way we present the info about the toggle (feel free to use/adapt as you see fit)

@robodoo delegate+

Comment thread content/applications/finance/accounting/taxes/tax_computation.rst Outdated
If a tax's :guilabel:`Included in Price` field is set to either :guilabel:`Tax Excluded` or
:guilabel:`Tax Included`, the tax's behavior will not be changed by the :guilabel:`Tax Excl. / Tax
Incl.` toggle on quotations, sales orders, purchase orders, and invoices.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about putting all the info about the toggle inside an alert block (could be a note instead, or even a sub-heading?)
I gave it a try, and I think it's easier to follow that way. I didn't include your note about using the toggle as I felt it wasn't necessary here. I put the rst just in case you want to go for it, but feel free to rephrase/adapt as you see fit.

Image
:guilabel:`Default` indicates that the tax follows the company-wide default.

:guilabel:`Tax Excluded` indicates that the tax amount is not included in the sales price. The tax
computation will therefore compute a tax amount on top of the sales price.

:guilabel:`Tax Included` indicates that the tax amount is included in the sales price. The tax
computation will therefore split the sales price into a tax-excluded base and the tax amount. This
makes it suitable for B2C sales in most countries, where prices are quoted tax-inclusive.

.. important::
   If the :guilabel:`Default` option is selected, using the :guilabel:`Tax Excl. / Tax Incl.` toggle
   on a specific quotation, sales order, purchase order, or invoice changes this tax's behavior for
   that record only.

   However, if a tax's :guilabel:`Included in Price` field is set to either :guilabel:`Tax Excluded`
   or :guilabel:`Tax Included`, the tax's behavior will not be changed by the :guilabel:`Tax Excl. /
   Tax Incl.` toggle on quotations, sales orders, purchase orders, and invoices.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this recommendation - I do like the alert block idea, but I feel like that leaves out a little bit of context that would be nice to add (both an intro sentence explaining the use case and the note I had explaining that you should add products before using the toggle). I've tried a sub-section as you suggested, which I like, but it does mean that we have a single H3. I prefer the sub-section but I'm open to suggestions if you prefer the alert block! Let me know :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info about the toggle felt a bit out of place with the rest of the page so that's why I wasn't sure about having a separate section, but it's clearer that way so go for it :)

@dade-odoo
dade-odoo force-pushed the saas-19.4-accounting-tax-incl-dade branch from 71b2d57 to 9b006f4 Compare September 1, 2026 11:30
@dade-odoo

Copy link
Copy Markdown
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Sep 1, 2026
closes #19634

Signed-off-by: Dallas Dean (dade) <dade@odoo.com>
@robodoo robodoo closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants