[IMP] inventory: operations valuation article clarification - #19849
Closed
fw-bot wants to merge 1 commit into
Closed
[IMP] inventory: operations valuation article clarification#19849fw-bot wants to merge 1 commit into
fw-bot wants to merge 1 commit into
Conversation
X-original-commit: 00e2ade Co-authored-by: Felicia Kuan <feku@odoo.com>
Collaborator
Collaborator
Author
|
This PR targets saas-19.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does and why it's needed
Clarifies the "How inventory operations affect valuation" article by retitling it to better reflect its scope and by explaining the distinction between the
Unit Costshown on a stock movement and theCostfield on the product form, which can otherwise be mistaken for the same value.Changes
Inventory Valuation
Unit Costis specific to each stock movement, and fixed its costing-method reference link.Costfield on the product form shows the average price of the product — even under the FIFO costing method — and is affected by outbound stock movements in that case; it is informational only and not used for valuation.Additional changes during review
These changes were made in a follow-up commit (implementing Felicia's review suggestion) and later squashed into the final commit, all within
content/applications/inventory_and_mrp/inventory/inventory_valuation/operations_valuation.rst::guilabel:→ italics for "Cost" field (lines 187-190)Changed
:guilabel:Cost`` to plain italic Cost throughout the callout, since it refers to the product form field conceptually rather than as clickable UI.New clarification on Cost field's role in adjustments (lines 192-194)
Replaced the old closing line ("The Cost field is not used for valuation, and is only informational") with a more accurate statement:
Renamed virtual location (line ~319)
Inventory Loss location -> Inventory adjustment location, matching Odoo's actual naming.
Reworded valuation trigger for adjustments (lines 318-322)
Changed from "based on the current unit cost of the product" to "based on the difference between the counted quantity and the expected quantity" - a more precise description of what drives the value change.
New paragraph added (lines 328-330)
Net effect: 24 insertions, 8 deletions. The core addition clarifies that inventory adjustments always use the product's averaged cost as the unit price - even under FIFO - correcting the earlier (less precise) statement that the Cost field was purely informational.
This
19.0PR can be FWP up tomaster.Forward-Port-Of: #19838