[IMP] email: add mail.default.from_filter #2694

StraubCreative · 2022-09-08T00:37:32Z

Cherry-pick of #2055

The mail.default.from_filter ICP was introduced by odoo/odoo#80943 and is set by default on all new cloud databases.

The documentation for Odoo default SMTP users needs to be adapted.

robodoo · 2022-09-08T00:38:17Z

Pull request status dashboard.

std-odoo · 2022-09-08T06:25:55Z

ok for me for the default email part :)

tiku-odoo

@samueljlieber This PR is ready for a technical review.

@std-odoo Can formally approve this PR when you have a moment?

std-odoo

LGTM for the default email stuff :)
(I don't know enough the rest to know if it's 100% correct)

samueljlieber · 2022-09-08T15:26:26Z

Thanks @std-odoo for your speedy review!

I'm tagging @mivu-odoo for a final content review 🙂

CC @tiku-odoo

mivu-odoo

Hello @samueljlieber and @tiku-odoo! Thank you for your patience on this PR.

I found a couple of instances of familiar second-person pronoun use and awkward language. Please let me know if you need any clarifications on my suggestions.

When you're ready, please tag me for a final look. Thank you 😸

content/applications/general/email_communication/email_domain.rst

samueljlieber · 2022-09-21T17:57:04Z

Hi @mivu-odoo 🙂
Thank you for the edits! I updated the doc per your suggestions. Ready for another review 👍

mivu-odoo

Hello @samueljlieber and @tiku-odoo!

Couple of revisions needed for abbreviations. Let me know when you're ready, and I can do a final check. Thank you!

content/applications/general/email_communication/email_domain.rst

samueljlieber · 2022-09-22T13:47:07Z

Hi @mivu-odoo ready for a final check, thank you! 🙂

mivu-odoo

Hello @samueljlieber and @tiku-odoo!

Some small changes left, but once those go through feel free to send it straight to ZST for final technical review. No need to tag me again! Thank you 😸

content/applications/general/email_communication/email_domain.rst

samueljlieber · 2022-09-23T14:03:46Z

Hi @StraubCreative, this doc is ready for a final technical review 🙂
Thank you!

StraubCreative · 2022-12-08T21:00:09Z

Merge conflict solved on b5773fb. Technical review to follow...

StraubCreative

Hi @tiku-odoo
I had a couple of content suggestions and a few small edits for the RST.
Can you please approve/improve the content suggestions and then work with @samueljlieber to get an updated version before I pass to DR?
Thank you 🙏

content/applications/general/email_communication/email_domain.rst

tiku-odoo · 2022-12-09T16:37:30Z

@StraubCreative 👍 Thanks for making the suggestions on this doc. I've successfully made the changes and pushed the doc. It is ready for you to review again.

Thanks,
Tim

StraubCreative

Hi @tiku-odoo
Nice job on the revisions.
I only caught one thing where line breaks too early. I'll fix it and send over to DR 👍

StraubCreative · 2022-12-09T22:13:11Z

content/applications/general/email_communication/email_domain.rst

line 16 breaks too early.

Suggested change

Messages sent in the chatter from internal database users to external users (such as partners,

customers, or vendors) are relayed on behalf of the database users. Messages

sent back to the chatter from external users will appear in the chatter from their respective email

addresses, or as they are listed in their Contacts record.

Messages sent in the chatter from internal database users to external users (such as partners,

customers, or vendors) are relayed on behalf of the database users. Messages sent back to the

chatter from external users will appear in the chatter from their respective email addresses, or as

they are listed in their Contacts record.

StraubCreative · 2022-12-10T00:11:39Z

All good to me as of 058e099.

@odoo/doc-review this doc about email domain configuration is ready for your review 🙂

Feyensv

@robodoo delegate+

LGTM, only one minor remark on the fly ;)

content/applications/general/email_communication/email_domain.rst

samueljlieber · 2022-12-14T15:47:12Z

266e4fb removed the comma in the title on line 152: #2694 (review)

samueljlieber · 2022-12-15T14:12:48Z

@robodoo r+

robodoo · 2022-12-15T14:13:20Z

I'm sorry, @samueljlieber. I'm afraid I can't do that.

Feyensv · 2022-12-15T14:48:34Z

@robodoo r+

(strange that the r+ wasn't accepted, any idea @xmo-odoo ?)

closes #2694 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

C3POdoo requested a review from a team September 8, 2022 00:38

StraubCreative force-pushed the 15.0-email-add-filter-to-mail-doc-jqu branch from b15a224 to 81ad8f0 Compare September 8, 2022 00:39

StraubCreative mentioned this pull request Sep 8, 2022

Add mail.default.from_filter in mail documentation #2055

Closed

StraubCreative requested review from std-odoo and tiku-odoo September 8, 2022 00:45

StraubCreative assigned samueljlieber Sep 8, 2022

tiku-odoo approved these changes Sep 8, 2022

View reviewed changes

std-odoo approved these changes Sep 8, 2022

View reviewed changes

samueljlieber force-pushed the 15.0-email-add-filter-to-mail-doc-jqu branch from 81ad8f0 to 068f0da Compare September 8, 2022 15:21

samueljlieber requested a review from mivu-odoo September 8, 2022 15:26

mivu-odoo suggested changes Sep 20, 2022

View reviewed changes

samueljlieber force-pushed the 15.0-email-add-filter-to-mail-doc-jqu branch from 068f0da to fcc53a2 Compare September 21, 2022 17:55

samueljlieber requested a review from mivu-odoo September 21, 2022 17:57

mivu-odoo suggested changes Sep 22, 2022

View reviewed changes

samueljlieber force-pushed the 15.0-email-add-filter-to-mail-doc-jqu branch from fcc53a2 to 39dc233 Compare September 22, 2022 13:45

samueljlieber requested a review from mivu-odoo September 22, 2022 13:47

mivu-odoo approved these changes Sep 22, 2022

View reviewed changes

samueljlieber force-pushed the 15.0-email-add-filter-to-mail-doc-jqu branch from 39dc233 to a26c623 Compare September 23, 2022 13:55

StraubCreative requested review from samueljlieber and removed request for samueljlieber September 23, 2022 20:15

StraubCreative requested review from samueljlieber and removed request for samueljlieber December 2, 2022 21:30

StraubCreative force-pushed the 15.0-email-add-filter-to-mail-doc-jqu branch from a26c623 to b5773fb Compare December 7, 2022 19:42

tiku-odoo requested a review from jevs-odoo December 8, 2022 20:00

StraubCreative commented Dec 8, 2022

View reviewed changes

tiku-odoo force-pushed the 15.0-email-add-filter-to-mail-doc-jqu branch from b5773fb to af820a8 Compare December 9, 2022 16:35

StraubCreative commented Dec 9, 2022

View reviewed changes

StraubCreative force-pushed the 15.0-email-add-filter-to-mail-doc-jqu branch from af820a8 to 058e099 Compare December 9, 2022 23:14

StraubCreative requested a review from a team December 10, 2022 00:11

Feyensv approved these changes Dec 12, 2022

View reviewed changes

content/applications/general/email_communication/email_domain.rst Outdated Show resolved Hide resolved

[IMP] email: add mail.default.from_filter

266e4fb

samueljlieber force-pushed the 15.0-email-add-filter-to-mail-doc-jqu branch from 058e099 to 266e4fb Compare December 14, 2022 15:45

robodoo pushed a commit that referenced this pull request Dec 15, 2022

[IMP] email: add mail.default.from_filter

df041b1

closes #2694 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

fw-bot mentioned this pull request Dec 15, 2022

[FW][IMP] email: add mail.default.from_filter #3205

Closed

robodoo temporarily deployed to merge December 15, 2022 17:50 Inactive

robodoo closed this Dec 15, 2022

This was referenced Dec 15, 2022

[FW][IMP] email: add mail.default.from_filter #3207

Closed

[FW][IMP] email: add mail.default.from_filter #3209

Closed

[FW][IMP] email: add mail.default.from_filter #3211

Closed

-Messages sent in the chatter from internal database users to external users (such as partners,
-customers, or vendors) are relayed on behalf of the database users. Messages
-sent back to the chatter from external users will appear in the chatter from their respective email
-addresses, or as they are listed in their Contacts record.
+Messages sent in the chatter from internal database users to external users (such as partners,
+customers, or vendors) are relayed on behalf of the database users. Messages sent back to the
+chatter from external users will appear in the chatter from their respective email addresses, or as
+they are listed in their Contacts record.

[IMP] email: add mail.default.from_filter #2694

[IMP] email: add mail.default.from_filter #2694

Uh oh!

Conversation

StraubCreative commented Sep 8, 2022

Uh oh!

robodoo commented Sep 8, 2022

Uh oh!

std-odoo commented Sep 8, 2022

Uh oh!

tiku-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

std-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

samueljlieber commented Sep 8, 2022

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samueljlieber commented Sep 21, 2022

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samueljlieber commented Sep 22, 2022

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samueljlieber commented Sep 23, 2022

Uh oh!

StraubCreative commented Dec 8, 2022

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tiku-odoo commented Dec 9, 2022

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

StraubCreative Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

StraubCreative commented Dec 10, 2022