-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[FW][IMP] CRM: updating flow and screenshots about lead mining #3118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@StraubCreative @AntoineVDV cherrypicking of pull request #2535 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. X-original-commit: 02ef871
774be94 to
dc81ab2
Compare
|
Hi @AntoineVDV Tagging you here for a quick review to make sure I did this right. What I did on dc81ab2:
Thanks and please let me know when you have a moment 🙏 |
Hi, yes that's the general idea, but you added extra steps. The fw-bot already performs the cherry-pick of 4af536d, so you don't need to do it again. It changes nothing to the conflict to resolve but it does add an extra commit to squash later as you saw. In general, you could just:
|
|
@robodoo r+ |
Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. closes #3118 X-original-commit: 02ef871 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Task: 2543815
Cherry pick from #998
Omitted changes proposed in the track_leads directory (e.g.
lead_scoring.rst+ image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary.What’s left over are the original proposed changes in #998, within the acquire_leads directory which include updates to
lead_mining.rstand corresponding image files.On top of these proposals, I went ahead and made the following changes:
LM1.png,LM6.png,LM7.png)Forward-Port-Of: #2535