-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[IMP] live chat: update ratings doc #4063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4260dec to
4d73301
Compare
|
Additional changes made |
3c71069 to
9fa0fff
Compare
9fa0fff to
4487c13
Compare
4487c13 to
2a836ec
Compare
|
@larm-odoo This is ready for your review. Thanks! |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great doc and nice improvements! There was one small section where what I had to do was a little off, so I changed that part, and I clarified a few spots where I was confused (figuring if I am someone else could be =). And I added a suggestion of something to add with the reporting part. LMK if you have any questions on my comments.
bce455d to
e25156d
Compare
|
Hi @tiku-odoo, this one is ready for your review. Thanks! |
tiku-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jero-odoo This doc is ready for you. I've made a few suggestions, looks excellent as it stands.
Nice work, and looking forward to seeing this published.
*I did a functionality review through 16.3 runbot
Tim
👍
Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com>
e25156d to
5076908
Compare
|
Thank you! Sending to @odoo/us-doc-review for tech review and final. |
|
hi @jero-odoo i need approvals from @tiku-odoo and @larm-odoo first before @samueljlieber or I review, thanks! |
tiku-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the two open comments outstanding that need clarification. Good to move forward! 👍
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good- I didn't actually click approve last time! Sorry!
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great doc, thanks @jero-odoo 👍
@robodoo r+
|
@jero-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed): |
This doc is still in progress, I am waiting to hear back from PE/PO about a few details (specifically publishing the ratings on the website/portal).