Skip to content

[IMP] test_generic: add warning when templates is noupdate#1981

Closed
frva-odoo wants to merge 1 commit intoodoo:19.0from
odoo-dev:19.0-testing-template-updatable-warning-frva
Closed

[IMP] test_generic: add warning when templates is noupdate#1981
frva-odoo wants to merge 1 commit intoodoo:19.0from
odoo-dev:19.0-testing-template-updatable-warning-frva

Conversation

@frva-odoo
Copy link
Copy Markdown
Contributor

@frva-odoo frva-odoo commented Apr 9, 2026

Templates should be updated.
This PR modifies the generic test _check_update_status to also test templates,
and raise a warning if those are marked as noupdate="1".
It also removes the noupdate attributes found for the templates.

TASK-6064474

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 9, 2026

Pull request status dashboard

@frva-odoo frva-odoo force-pushed the 19.0-testing-template-updatable-warning-frva branch from bfe1034 to d941060 Compare April 9, 2026 10:45
Comment thread 3pl_logistic_company/data/portal_templates.xml
@@ -71,6 +71,7 @@
"ir.ui.menu",
"ir.ui.view",
"knowledge.article",
"template",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably have to add portal.entry to the list as well in the forward port

@vava-odoo
Copy link
Copy Markdown
Collaborator

@robodoo help

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 13, 2026

Currently available commands for @vava-odoo:

command
help displays this help
r(eview)+ approves the PR, if it's a forwardport also approves all non-detached parents
r(eview)=<number> only approves the specified parents
r(eview)- removes approval of a previously approved PR, if the PR is staged the staging will be cancelled
retry re-tries staging a PR in the "error" state
fw=no does not forward-port this PR
fw=default forward-ports this PR normally
fw=skipci does not wait for a forward-port's statuses to succeed before creating the next one
fw=skipmerge does not wait for the source to be merged before creating forward ports
up to <branch> only ports this PR forward to the specified branch (included)
merge integrate the PR with a simple merge commit, using the PR description as message
rebase-merge rebases the PR on top of the target branch the integrates with a merge commit, using the PR description as message
rebase-ff rebases the PR on top of the target branch, then fast-forwards
squash squashes the PR as a single commit on the target branch, using the PR description as message
delegate+ grants approval rights to the PR author
delegate=<...> grants approval rights on this PR to the specified github users
nice only stages the PR if there's room in the batch after default PRs
default stages the PR normally
priority tries to stage this PR first, then adds default PRs if the staging has room
alone stages this PR only with other PRs of the same priority
cancel=staging automatically cancels the current staging when this PR becomes ready
override=<...> marks overridable statuses as successful
check fetches or refreshes PR metadata, resets mergebot state
remindme:<branch>=<message> When the PR gets forward-ported to , ping you with . can be quoted if it needs spaces.

Note: this help text is dynamic and will change with the state of the PR.

@vava-odoo
Copy link
Copy Markdown
Collaborator

@robodoo remindme:saas-19.1="add portal.entry to the list"
let's try this

@vava-odoo vava-odoo changed the title [IMP] tests: templates add warning when not updated [IMP] test_generic: add warning when templates is noupdate Apr 13, 2026
@vava-odoo
Copy link
Copy Markdown
Collaborator

@robodoo squash

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 13, 2026

Merge method set to squash.

Templates should be updated.
This commit modify the generic test _check_update_status to also test templates,
and raise a warning if those are marked as noupdate="1".
It also removes the noupdate attributes found for the templates.

TASK-6064474
@frva-odoo frva-odoo force-pushed the 19.0-testing-template-updatable-warning-frva branch from d941060 to f0e1aaa Compare April 13, 2026 11:24
@vava-odoo
Copy link
Copy Markdown
Collaborator

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 13, 2026
Templates should be updated.
This commit modify the generic test _check_update_status to also test templates,
and raise a warning if those are marked as noupdate="1".
It also removes the noupdate attributes found for the templates.

TASK-6064474

closes #1981

Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
@robodoo robodoo closed this in d4e299e Apr 13, 2026
@fw-bot fw-bot deleted the 19.0-testing-template-updatable-warning-frva branch April 20, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants