[IMP] *: Do not pollute message and notification box when installing an industry#1982
Closed
fw-bot wants to merge 1 commit intoodoo:saas-19.1from
Conversation
Collaborator
|
|
Author
|
@amas-odoo @vava-odoo cherrypicking of pull request #1633 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
you can use 
amas-odoo
force-pushed
the
saas-19.1-19.0-prevent-message-notification-while-installing-industry-amas-496270-fw
branch
from
83faed4 to
97d38d6
Compare
…an industry
- Remove res_users.xml forcing notification_type='inbox' so modules generate
mails again.
- Read generated mails via _read_group and browse related records.
- Inspect linked mail.activity and handle upsell activities separately:
- Identify upsell activities from note content.
- Ignore upsell activities without external IDs when their count matches
generated mails.
- Process remaining activities to detect missing contexts.
- Suggest required contexts to prevent message/mail pollution.
- Log warnings with external IDs and recommended contexts.
- Add validation on XML <function> nodes to ensure required mail-prevention
contexts are set.
- Introduce helper log_warning to standardize missing-context warnings.
- Add specific checks:
- slide.channel: ensure publish_template_id is set to False.
- sale.order.action_confirm: require mail_auto_subscribe_no_notify and
mail_notrack when subscription SO is present.
- Functions defined in FUNCTION_CONTEXT_DICT_WITHOUT_USER:
enforce mail_auto_subscribe_no_notify.
- write calls updating user_id / user_ids: require
mail_auto_subscribe_no_notify to prevent unwanted followers/mails.
- Safely parse function context using literal_eval with fallback handling.
Task ID: 5262306
X-original-commit: 80a1604
amas-odoo
force-pushed
the
saas-19.1-19.0-prevent-message-notification-while-installing-industry-amas-496270-fw
branch
from
97d38d6 to
11d2ebe
Compare
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 15, 2026
…an industry
- Remove res_users.xml forcing notification_type='inbox' so modules generate
mails again.
- Read generated mails via _read_group and browse related records.
- Inspect linked mail.activity and handle upsell activities separately:
- Identify upsell activities from note content.
- Ignore upsell activities without external IDs when their count matches
generated mails.
- Process remaining activities to detect missing contexts.
- Suggest required contexts to prevent message/mail pollution.
- Log warnings with external IDs and recommended contexts.
- Add validation on XML <function> nodes to ensure required mail-prevention
contexts are set.
- Introduce helper log_warning to standardize missing-context warnings.
- Add specific checks:
- slide.channel: ensure publish_template_id is set to False.
- sale.order.action_confirm: require mail_auto_subscribe_no_notify and
mail_notrack when subscription SO is present.
- Functions defined in FUNCTION_CONTEXT_DICT_WITHOUT_USER:
enforce mail_auto_subscribe_no_notify.
- write calls updating user_id / user_ids: require
mail_auto_subscribe_no_notify to prevent unwanted followers/mails.
- Safely parse function context using literal_eval with fallback handling.
Task ID: 5262306
closes #1982
X-original-commit: 80a1604
Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
Signed-off-by: Amardeep Sharma (amas) <amas@odoo.com>
vava-odoo
reviewed
Apr 15, 2026
| } | ||
| CONTEXT_MODELS_DICT = { | ||
| 'calendar.event': 'no_mail_to_attendees', | ||
| 'helpdesk.ticket': 'mail_notrack', |
Collaborator
There was a problem hiding this comment.
maybe this one was useful to keep, no?
EDIT: talking about no_vat_validation on res.partner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mails again.
generated mails.
contexts are set.
mail_notrack when subscription SO is present.
enforce mail_auto_subscribe_no_notify.
mail_auto_subscribe_no_notify to prevent unwanted followers/mails.
Context Usedwhen users are automatically added as followers. By default this is False,
meaning notifications are sent — enable it to stay silent.
avoids sending them a notification about the new activity.
automatic “value changed” messages are posted.
Task ID: 5262306
Forward-Port-Of: #1633