[FIX] booking_engine: add test for unavailability due to calendar leave without resource#2035
Closed
fw-bot wants to merge 2 commits intoodoo:saas-19.2from
Conversation
Collaborator
|
|
Author
|
This PR targets saas-19.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Author
|
@abdrahmanrashed @vava-odoo ci/industry failed on this forward-port PR |
…ve without resource This commit adds test to check you can't book rooms when the rental period overlaps with`resource.calendar.leaves` with no `resource_id` X-original-commit: ef20ac1
This commit updates the test_booking_engine to comply with standard changes: - Replace resource_id with resource_ids to support multiple resources. - Rename time_type to count_as following the updated field definition in the standard. Ref Commit - odoo/odoo@d37cf89#diff-7767bd14c6d3c44c406fd04f3d1c1deda8936898a0e725b7e4050faca2436ac3
dhrs-odoo
force-pushed
the
saas-19.2-19.0-booking_engine-add-missing-overbooking-test-aras-519219-fw
branch
from
184b269 to
ba6124c
Compare
Author
|
@abdrahmanrashed @vava-odoo this PR has become a normal PR because head updated from 184b269 to ba6124c. It must be merged to be forward-ported further. |
Collaborator
|
@robodoo r+ |
Collaborator
|
@abdrahmanrashed @vava-odoo because this PR has multiple commits, I need to know how to merge it:
|
Collaborator
|
@robodoo rebase-ff |
Collaborator
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2026
This commit updates the test_booking_engine to comply with standard changes: - Replace resource_id with resource_ids to support multiple resources. - Rename time_type to count_as following the updated field definition in the standard. Ref Commit - odoo/odoo@d37cf89#diff-7767bd14c6d3c44c406fd04f3d1c1deda8936898a0e725b7e4050faca2436ac3 closes #2035 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2026
This commit updates the test_booking_engine to comply with standard changes: - Replace resource_id with resource_ids to support multiple resources. - Rename time_type to count_as following the updated field definition in the standard. Ref Commit - odoo/odoo@d37cf89#diff-7767bd14c6d3c44c406fd04f3d1c1deda8936898a0e725b7e4050faca2436ac3 closes #2035 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
fw-bot
deleted the
saas-19.2-19.0-booking_engine-add-missing-overbooking-test-aras-519219-fw
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds test to check you can't book rooms when the rental period overlaps with
resource.calendar.leaveswith noresource_idForward-Port-Of: #2029