[ADD] construction_developer: add project progress report#2044
Open
mega-odoo wants to merge 6 commits into
Open
[ADD] construction_developer: add project progress report#2044mega-odoo wants to merge 6 commits into
mega-odoo wants to merge 6 commits into
Conversation
Collaborator
|
|
mega-odoo
force-pushed
the
saas-19.2-construction-developer-progress-report-mega
branch
2 times, most recently
from
05a11a1 to
e5121ab
Compare
mega-odoo
force-pushed
the
saas-19.2-construction-developer-progress-report-mega
branch
from
e5121ab to
f1a0916
Compare
mega-odoo
force-pushed
the
saas-19.2-construction-developer-progress-report-mega
branch
9 times, most recently
from
f9f819f to
cce26d6
Compare
pgu-odoo
reviewed
May 20, 2026
Contributor
pgu-odoo
left a comment
pgu-odoo
left a comment
There was a problem hiding this comment.
@vava-odoo PR is ready for your review.
@mega-odoo Good work!
Just a few comments.
| project_id = sale_order.project_id | ||
| action = env.ref('construction_developer.report_progress_saleorder').report_action(project_id) | ||
| if action.get('res_model') == 'base.document.layout': | ||
| action['context'] = dict( action.get('context', {}), active_model='sale.order', active_id=sale_order.id) |
Contributor
There was a problem hiding this comment.
Suggested change
| action['context'] = dict( action.get('context', {}), active_model='sale.order', active_id=sale_order.id) | |
| action['context'] = dict(action.get('context', {}), active_model='sale.order', active_id=sale_order.id) |
| </attribute> | ||
| </xpath> | ||
| </template> | ||
| <template id="prgress_report_document"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <template id="prgress_report_document"> | |
| <template id="progress_report_document"> |
mega-odoo
force-pushed
the
saas-19.2-construction-developer-progress-report-mega
branch
from
a7cd1d1 to
0fd7b97
Compare
vava-odoo
reviewed
May 22, 2026
Collaborator
vava-odoo
left a comment
vava-odoo
left a comment
There was a problem hiding this comment.
Some questions/comments on the implementation. Also, why does it target 19.2?
| <strong>Automated cost update</strong> - Automatically adjusted product costs and vendor list based on confirmed purchase orders and invoices. | ||
| </li> | ||
| <li> | ||
| <strong>Materials Need Management</strong> - Manage the sale order shopping list deciding for reservation, purchase and drop shipping. |
Collaborator
There was a problem hiding this comment.
why do you remove that one?
Comment on lines
+79
to
+80
| sale_order = records.order_id[:1] | ||
| project_id = sale_order.project_id |
Collaborator
There was a problem hiding this comment.
I don't get the logic here. You want to print all lines linked to the project. But the link could be on the SOL or the SO. Why don't you provide the project id somehow in the context?
| sale_order = records.order_id[:1] | ||
| project_id = sale_order.project_id | ||
| action = env.ref('construction_developer.report_progress_saleorder').report_action(project_id) | ||
| if action.get('res_model') == 'base.document.layout': |
| <field name="model_id" ref="sale.model_sale_order_line"/> | ||
| <field name="name">x_current_progress</field> | ||
| <field name="name">x_cumulated_progress</field> |
Collaborator
There was a problem hiding this comment.
I wouldn't change the field id and name, only the description
| <div class="col-4" name="original_order"> | ||
| <div class="mb-2"> | ||
| <strong>Original Order</strong> | ||
| <div t-field="orders[0].name"/> |
Collaborator
There was a problem hiding this comment.
is it possible to print without linked orders? I'd put a t-if on this div to ensure orders is not empty
| <t t-set="lines_to_report" t-value="order._get_order_lines_to_report()"/> | ||
| <t t-set="display_discount" t-value="any(line.discount for line in lines_to_report)"/> | ||
| <!-- Hide taxes AND show taxed amounts on lines (currently always False)--> | ||
| <!-- TODO: Remove `hide_taxes_details` and related conditions if this industry report is never intended to be inherited --> |
Collaborator
There was a problem hiding this comment.
was this discussed and decided? We could leave it for now in case
Generate a progress report for the projects. This helps standardize the data for architect/customer review and can be used as a legal document. Task ID: 5972435
mega-odoo
force-pushed
the
saas-19.2-construction-developer-progress-report-mega
branch
from
0fd7b97 to
16da484
Compare
mega-odoo
force-pushed
the
saas-19.2-construction-developer-progress-report-mega
branch
from
5fbffc6 to
dfe395b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate a progress report for the projects.
This helps standardize the data for architect/customer review and can be used as a legal document.
Task ID: 5972435