[ADD] .*: improve rental booking and housekeeping management by dhrs-odoo · Pull Request #2131 · odoo/industry

dhrs-odoo · 2026-05-11T07:34:45Z

add rental status indicators to quickly identify bookings for today's check-in, ongoing stays, and today's check-out directly from the view
remove the default today filter
add "Today's Check-In" and "Today's Check-Out" filters in the gantt view
add default group by stage on the housekeeping board
hide Guests tab and Tax button when no stay offer products are present in the SOL
add many2one_avatar widget on x_guest_partner_id field
hide the housekeeping section when the resource role is not linked to a stay offer product
update demo data so orders with a start date before today and an end date after today are automatically checked in
update demo data so orders with an end date before today are automatically checked out

Task-6144429

robodoo · 2026-05-11T07:34:48Z

vava-odoo · 2026-05-15T09:20:28Z

+    <field name="active" eval="True"/>
+    <field name="arch" type="xml">
+        <xpath expr="//filter[@name='conflict_shifts']" position="before">
+          <filter string="Today's Check In" name="filter_checkin_today" domain="[('x_rental_status', '=', 'pickup'), ('sale_order_id.rental_start_date', '&gt;=', 'today'), ('sale_order_id.rental_start_date', '&lt;', 'today +1d')]"/>


the spec says we should remove "my customer" filter. Did it drop from spec?

I didn't found that filter I discussed same with Savp

- add rental status indicators to quickly identify bookings for today's check-in, ongoing stays, and today's check-out directly from the view - remove the default today filter - add "Today's Check-In" and "Today's Check-Out" filters in the gantt view - add default group by stage on the housekeeping board - hide Guests tab and Tax button when no stay offer products are present in the SOL - add many2one_avatar widget on x_guest_partner_id field - hide the housekeeping section when the resource role is not linked to a stay offer product - update demo data so orders with a start date before today and an end date after today are automatically checked in - update demo data so orders with an end date before today are automatically checked out Task-6144429

abdrahmanrashed · 2026-05-20T11:52:30Z

+    if not order:
+        slot['x_booking_color'] = 5   # purple - internal
+    elif order.rental_status == 'pickup' and order.rental_start_date and today_start <= order.rental_start_date <= today_end:
+        slot['x_booking_color'] = 3   # yellow - check in due
+    elif order.rental_status == 'return' and order.rental_return_date and order.rental_return_date > today_end:
+        slot['x_booking_color'] = 10  # green - ongoing
+    elif order.rental_status == 'return' and order.rental_return_date and today_start <= order.rental_return_date <= today_end:
+        slot['x_booking_color'] = 4   # blue - check out due
+    elif (order.rental_status == 'pickup' and order.is_late) or (order.rental_status == 'return' and order.is_late):
+        slot['x_booking_color'] = 1   # red - attention
+    else:
+        slot['x_booking_color'] = False # grey - no focus


nitpick, feel free to do whatever you want though...

Suggested change

if not order:

slot['x_booking_color'] = 5 # purple - internal

elif order.rental_status == 'pickup' and order.rental_start_date and today_start <= order.rental_start_date <= today_end:

slot['x_booking_color'] = 3 # yellow - check in due

elif order.rental_status == 'return' and order.rental_return_date and order.rental_return_date > today_end:

slot['x_booking_color'] = 10 # green - ongoing

elif order.rental_status == 'return' and order.rental_return_date and today_start <= order.rental_return_date <= today_end:

slot['x_booking_color'] = 4 # blue - check out due

elif (order.rental_status == 'pickup' and order.is_late) or (order.rental_status == 'return' and order.is_late):

slot['x_booking_color'] = 1 # red - attention

else:

slot['x_booking_color'] = False # grey - no focus

slot['x_booking_color'] = False # grey - no focus

if not order: slot['x_booking_color'] = 5 # purple - internal

elif order.rental_status in ['pickup', 'return']:

if order.is_late: slot['x_booking_color'] = 1 # red - attention

elif order.rental_status == 'return':

if order.rental_return_date > today_end:

slot['x_booking_color'] = 10 # green - ongoing

elif order.rental_return_date and today_start <= order.rental_return_date <= today_end:

slot['x_booking_color'] = 4 # blue - check out due

elif order.rental_start_date and today_start <= order.rental_start_date <= today_end:

slot['x_booking_color'] = 3 # yellow - check in due

please no 🙃

vava-odoo · 2026-05-20T11:58:21Z

+    <field name="model_id" ref="planning.model_planning_slot"/>
+    <field name="name">x_rental_status</field>
+    <field name="related">sale_order_id.rental_status</field>
+    <field name="store">False</field>


does that really work? 😂

checked, yes 🫠

yes it's working

vava-odoo · 2026-05-20T11:59:36Z

+    if not order:
+        slot['x_booking_color'] = 5   # purple - internal
+    elif order.rental_status == 'pickup' and order.rental_start_date and today_start <= order.rental_start_date <= today_end:
+        slot['x_booking_color'] = 3   # yellow - check in due
+    elif order.rental_status == 'return' and order.rental_return_date and order.rental_return_date > today_end:
+        slot['x_booking_color'] = 10  # green - ongoing
+    elif order.rental_status == 'return' and order.rental_return_date and today_start <= order.rental_return_date <= today_end:
+        slot['x_booking_color'] = 4   # blue - check out due
+    elif (order.rental_status == 'pickup' and order.is_late) or (order.rental_status == 'return' and order.is_late):
+        slot['x_booking_color'] = 1   # red - attention
+    else:
+        slot['x_booking_color'] = False # grey - no focus


please no 🙃

vava-odoo · 2026-05-20T12:04:05Z

@robodoo r+ squash

robodoo · 2026-05-20T12:04:08Z

Merge method set to squash.

- add rental status indicators to quickly identify bookings for today's check-in, ongoing stays, and today's check-out directly from the view - remove the default today filter - add "Today's Check-In" and "Today's Check-Out" filters in the gantt view - add default group by stage on the housekeeping board - hide Guests tab and Tax button when no stay offer products are present in the SOL - add many2one_avatar widget on x_guest_partner_id field - hide the housekeeping section when the resource role is not linked to a stay offer product - update demo data so orders with a start date before today and an end date after today are automatically checked in - update demo data so orders with an end date before today are automatically checked out Task-6144429 closes #2192 Forward-port-of: #2131 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>

dhrs-odoo changed the title ~~[ADD] .*: improve rental booking and housekeeping managemen~~ [ADD] .*: improve rental booking and housekeeping management May 11, 2026

dhrs-odoo force-pushed the 19.0-imp-booking-engine-ux-dhrs branch 2 times, most recently from ff5b6c2 to 2d04fba Compare May 12, 2026 09:51

vava-odoo reviewed May 15, 2026

View reviewed changes

dhrs-odoo force-pushed the 19.0-imp-booking-engine-ux-dhrs branch from 2d04fba to 84df82c Compare May 19, 2026 05:44

vava-odoo reviewed May 19, 2026

View reviewed changes

Comment thread booking_engine/data/ir_ui_view.xml

dhrs-odoo force-pushed the 19.0-imp-booking-engine-ux-dhrs branch from 84df82c to f49e8a8 Compare May 20, 2026 06:58

vava-odoo reviewed May 20, 2026

View reviewed changes

Comment thread booking_engine/data/ir_model_fields.xml

abdrahmanrashed reviewed May 20, 2026

View reviewed changes

vava-odoo approved these changes May 20, 2026

View reviewed changes

robodoo closed this in 5e0786c May 20, 2026

robodoo temporarily deployed to merge May 20, 2026 12:07 Inactive

This was referenced May 20, 2026

[ADD] .*: improve rental booking and housekeeping management #2192

Closed

[ADD] .*: improve rental booking and housekeeping management #2198

Open

Conversation

dhrs-odoo commented May 11, 2026

Uh oh!

robodoo commented May 11, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vava-odoo commented May 20, 2026

Uh oh!

robodoo commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants