[FIX] booking_engine: active filter group_by instead of context value#2176
Closed
vava-odoo wants to merge 1 commit into
Closed
[FIX] booking_engine: active filter group_by instead of context value#2176vava-odoo wants to merge 1 commit into
vava-odoo wants to merge 1 commit into
Conversation
Collaborator
|
|
vava-odoo
force-pushed
the
19.0-booking-fix-orders-menu-vava
branch
from
a6bd2f8 to
2b88aea
Compare
Steps to reproduce: - Go to booking engine app > orders > open an order - Open the product catalog - Traceback Reason: the 'group_by' was kept in the context, although the view was changed to another model (product.template instead of sale.order). This leads to an error because the field (rental_status) does not exist on this model. This commit fixes the issue by activating a group_by filter on the Orders view by default instead of hardcoding the groupby key in the context. task-6218176
vava-odoo
force-pushed
the
19.0-booking-fix-orders-menu-vava
branch
from
2b88aea to
1f8b52c
Compare
dhrs-odoo
approved these changes
May 21, 2026
Contributor
dhrs-odoo
left a comment
dhrs-odoo
left a comment
There was a problem hiding this comment.
Hello @vava-odoo
LGTM 🚀
Collaborator
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 21, 2026
Steps to reproduce: - Go to booking engine app > orders > open an order - Open the product catalog - Traceback Reason: the 'group_by' was kept in the context, although the view was changed to another model (product.template instead of sale.order). This leads to an error because the field (rental_status) does not exist on this model. This commit fixes the issue by activating a group_by filter on the Orders view by default instead of hardcoding the groupby key in the context. task-6218176 closes #2176 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Reason:
the 'group_by' was kept in the context, although the view was changed to another model (product.template instead of sale.order). This leads to an error because the field (rental_status) does not exist on this model.
This commit fixes the issue by activating a group_by filter on the Orders view by default instead of hardcoding the groupby key in the context.
task-6218176