[FIX] *: prevent an error while validating the payment#2185
Open
dhgoy-odoo wants to merge 1 commit into
Open
Conversation
*= ['florist', 'bike_shop', 'museum', 'takeaway_restaurant', 'wine_merchant'] Currently, an error occurs while validating a POS payment in above industries. Step to reproduce: - Install the florist industry. - Open a POS session. - Validate a payment. ValidationError: Journal is required for payment methods. The issue occurs because some POS payment methods are created without a journal_id. The journal_id field is mandatory for payment methods, and payment validation expects valid journals on all configured payment methods. To fix this issue, create a cash journal and assign it to the cash payment method, and assign a bank journal to the card payment method. In the takeaway restaurant, the same cash payment method was used across multiple POS configurations. If a journal is assigned to the shared cash payment method, it raises a validation error because the same cash payment method cannot be used in different POS configurations. To fix this issue, create separate cash journals for different POS configurations and assign them to their respective cash payment methods. Task ID-6193655
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*= ['florist', 'bike_shop', 'museum', 'takeaway_restaurant', 'wine_merchant']
Currently, an error occurs while validating a POS payment in above industries.
Step to reproduce:
ValidationError: Journal is required for payment methods.
The issue occurs because some POS payment methods are created without a
journal_id. The journal_id field is mandatory for payment methods,
and payment validation expects valid journals on all configured payment
methods.
To fix this issue, create a cash journal and assign it to the cash payment
method, and assign a bank journal to the card payment method.
In the takeaway restaurant, the same cash payment method was used across
multiple POS configurations. If a journal is assigned to the shared cash payment
method, it raises a validation error because the same cash payment method
cannot be used in different POS configurations. To fix this issue, create
separate cash journals for different POS configurations and assign them to
their respective cash payment methods.
Task ID-6193655