Skip to content

[FIX] print: figure border wrong render - #9366

Closed
hokolomopo wants to merge 1 commit into
saas-19.3from
saas-19.3-fix-print-figure-border-adrm
Closed

[FIX] print: figure border wrong render#9366
hokolomopo wants to merge 1 commit into
saas-19.3from
saas-19.3-fix-print-figure-border-adrm

Conversation

@hokolomopo

Copy link
Copy Markdown
Contributor

Description

When printing, the figure border was drawn with a strokeRect. But its argument were wrong, strokeRect draw a border centered of the rectangle given as args, which mean that if we want a border to be drawn inside the rectangle we have to offset it by half a pixel.

Task: 6458624

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

When printing, the figure border was drawn with a `strokeRect`. But
its argument were wrong, `strokeRect` draw a border centered of the
rectangle given as args, which mean that if we want a border to be drawn
inside the rectangle we have to offset it by half a pixel.

Task: 6458624
@robodoo

robodoo commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Pull request status dashboard

@pro-odoo pro-odoo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Aug 31, 2026
When printing, the figure border was drawn with a `strokeRect`. But
its argument were wrong, `strokeRect` draw a border centered of the
rectangle given as args, which mean that if we want a border to be drawn
inside the rectangle we have to offset it by half a pixel.

closes #9366

Task: 6458624
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants