[FW][FIX] point_of_sale: proper handling of caba taxes #202479
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robodoo
added
forwardport
|
|
|
@svfu-odoo @oco-odoo cherrypicking of pull request #201812 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
svfu-odoo
force-pushed
the
18.0-16.0-fix_caba_pos_tax_report-svfu-423797-fw
branch
from
0a0d358 to
42b14c0
Compare
C3POdoo
requested review from
a team and
davidmonnom
and removed request for
a team
We do not create create caba moves anymore for PoS session closing moves. (See commits 2f62d5c and 66e3696) But now there are 2 issues when using (only) caba taxes in a PoS session. (1) The closing move does not appear on the tax report. (2) The closing move line do not get the right tax tags (they do not have any). Issue (1) is solved by making pos closing moves `always_tax_exigible`. (In case they did not creat cash basis entries; for backwards compatibility). Issue (2) is solved by telling the tax computation for the lines to include caba taxes (instead of just changing the account to be the "final" account and not the caba transition account). opw-4355124 X-original-commit: 88d9c10
svfu-odoo
force-pushed
the
18.0-16.0-fix_caba_pos_tax_report-svfu-423797-fw
branch
from
42b14c0 to
7dedd98
Compare
smetl
approved these changes
Mar 19, 2025
This was referenced Mar 19, 2025
omar-sherif9992
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 26, 2025
We do not create create caba moves anymore for PoS session closing moves. (See commits 2f62d5c and 66e3696) But now there are 2 issues when using (only) caba taxes in a PoS session. (1) The closing move does not appear on the tax report. (2) The closing move line do not get the right tax tags (they do not have any). Issue (1) is solved by making pos closing moves `always_tax_exigible`. (In case they did not creat cash basis entries; for backwards compatibility). Issue (2) is solved by telling the tax computation for the lines to include caba taxes (instead of just changing the account to be the "final" account and not the caba transition account). opw-4355124 closes odoo#202479 X-original-commit: 88d9c10 Related: odoo/enterprise#81747 Signed-off-by: Olivier Colson (oco) <oco@odoo.com> Signed-off-by: Laurent Smet (las) <las@odoo.com>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 27, 2025
We do not create create caba moves anymore for PoS session closing moves. (See commits 2f62d5c0d78371be70586c79cb2b5931e733b042 and 66e3696b4f06c657ff71af30178f0ac69d552632) But now there are 2 issues when using (only) caba taxes in a PoS session. (1) The closing move does not appear on the tax report. (2) The closing move line do not get the right tax tags (they do not have any). Issue (1) is solved by making pos closing moves `always_tax_exigible`. (In case they did not creat cash basis entries; for backwards compatibility). Issue (2) is solved by telling the tax computation for the lines to include caba taxes (instead of just changing the account to be the "final" account and not the caba transition account). opw-4355124 closes odoo/odoo#202479 X-original-commit: 88d9c101e67869f09409990f7195c7ca6bbc0c43 Related: odoo/enterprise#81747 Signed-off-by: Olivier Colson (oco) <oco@odoo.com> Signed-off-by: Laurent Smet (las) <las@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not create create caba moves anymore for PoS session closing moves.
(See commits 2f62d5c and 66e3696)
But now there are 2 issues when using (only) caba taxes in a PoS session.
(1) The closing move does not appear on the tax report.
(2) The closing move line do not get the right tax tags (they do not have any).
Issue (1) is solved by making pos closing moves
always_tax_exigible.(In case they did not creat cash basis entries; for backwards compatibility).
Issue (2) is solved by telling the tax computation for the lines to include caba taxes
(instead of just changing the account to be the "final" account and not
the caba transition account).
opw-4355124
Forward-Port-Of: #202308
Forward-Port-Of: #201812