[FW][FIX] project_timesheet_holidays: restore public holiday timesheets a…#153273
Closed
fw-bot wants to merge 1 commit intoodoo:masterfrom
Conversation
…fter refusal Before this commit, if a public holiday was created on dates overlapping an existing validated leave, the timesheet entries for the public holiday would not be created as they already existed for the leave. If the leave was then refused or cancelled, the timesheet records linked to it would be removed and the employee would have missing timesheet entries for the public holiday. This commit fixes this behavior by recreating the public holiday timesheet records for the affected employees when refusing their leave. opw-3550523 linked to com: odoo#145522 X-original-commit: 5eb6054
Contributor
|
|
Contributor
Author
|
@goffauxs @xavierbol this PR targets master and is the last of the forward-port chain containing: To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
Author
|
@goffauxs @xavierbol ci/style failed on this forward-port PR |
Contributor
Author
|
@goffauxs @xavierbol ci/security failed on this forward-port PR |
Contributor
|
fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 10, 2024
…fter refusal Before this commit, if a public holiday was created on dates overlapping an existing validated leave, the timesheet entries for the public holiday would not be created as they already existed for the leave. If the leave was then refused or cancelled, the timesheet records linked to it would be removed and the employee would have missing timesheet entries for the public holiday. This commit fixes this behavior by recreating the public holiday timesheet records for the affected employees when refusing their leave. opw-3550523 linked to com: #145522 closes #153273 X-original-commit: 5eb6054 Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
fw-bot
deleted the
master-16.0-opw-3550523-project-timesheet-holidays-fix-restore-global-leave-on-refuse-sigo-w0CN-fw
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fter refusal
Before this commit, if a public holiday was created on dates overlapping an existing validated leave, the timesheet entries for the public holiday would not be created as they already existed for the leave. If the leave was then refused or cancelled, the timesheet records linked to it would be removed and the employee would have missing timesheet entries for the public holiday.
This commit fixes this behavior by recreating the public holiday timesheet records for the affected employees when refusing their leave.
opw-3550523
linked to com: #145522
Forward-Port-Of: #153118
Forward-Port-Of: #151522