[FIX] mail: fix error when sending mail notifications with no author #194569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the `_is_internal` on it. When the author is `False`, the function generating the mail crashes as the `_is_internal` function is undefined on a boolean variable. To address this issue, we will ensure the existence of the author before invoking any methods defined in the `res.users` model. This solution prevents errors and ensures the email template functions correctly. see: odoo/odoo/odoo#190390 Task-4128966
|
|
|
@robodoo r+ |
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 22, 2025
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the `_is_internal` on it. When the author is `False`, the function generating the mail crashes as the `_is_internal` function is undefined on a boolean variable. To address this issue, we will ensure the existence of the author before invoking any methods defined in the `res.users` model. This solution prevents errors and ensures the email template functions correctly. see: odoo/odoo/odoo#190390 Task-4128966 closes odoo#194569 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 23, 2025
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the `_is_internal` on it. When the author is `False`, the function generating the mail crashes as the `_is_internal` function is undefined on a boolean variable. To address this issue, we will ensure the existence of the author before invoking any methods defined in the `res.users` model. This solution prevents errors and ensures the email template functions correctly. see: odoo/odoo/odoo#190390 Task-4128966 closes odoo#194569 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 26, 2025
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the `_is_internal` on it. When the author is `False`, the function generating the mail crashes as the `_is_internal` function is undefined on a boolean variable. To address this issue, we will ensure the existence of the author before invoking any methods defined in the `res.users` model. This solution prevents errors and ensures the email template functions correctly. see: odoo/odoo/odoo#190390 Task-4128966 closes odoo#194569 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Jan 27, 2025
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the `_is_internal` on it. When the author is `False`, the function generating the mail crashes as the `_is_internal` function is undefined on a boolean variable. To address this issue, we will ensure the existence of the author before invoking any methods defined in the `res.users` model. This solution prevents errors and ensures the email template functions correctly. see: odoo/odoo/#190390 Task-4128966 closes odoo/odoo#194569 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 29, 2025
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the `_is_internal` on it. When the author is `False`, the function generating the mail crashes as the `_is_internal` function is undefined on a boolean variable. To address this issue, we will ensure the existence of the author before invoking any methods defined in the `res.users` model. This solution prevents errors and ensures the email template functions correctly. see: odoo/odoo/odoo#190390 Task-4128966 closes odoo#194569 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 29, 2025
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the `_is_internal` on it. When the author is `False`, the function generating the mail crashes as the `_is_internal` function is undefined on a boolean variable. To address this issue, we will ensure the existence of the author before invoking any methods defined in the `res.users` model. This solution prevents errors and ensures the email template functions correctly. see: odoo/odoo/odoo#190390 Task-4128966 closes odoo#194569 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
fw-bot
deleted the
18.0-mail-fix-error-when-sending-mail-notifications-with-no-author-jbn
branch
StephaneMangin
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Feb 6, 2025
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the `_is_internal` on it. When the author is `False`, the function generating the mail crashes as the `_is_internal` function is undefined on a boolean variable. To address this issue, we will ensure the existence of the author before invoking any methods defined in the `res.users` model. This solution prevents errors and ensures the email template functions correctly. see: odoo/odoo/odoo#190390 Task-4128966 closes odoo#194569 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the
_is_internalon it. When the author isFalse, the function generating the mail crashes as the_is_internalfunction is undefined on a boolean variable.To address this issue, we will ensure the existence of the author before invoking any methods defined in the
res.usersmodel. This solution prevents errors and ensures the email template functions correctly.see: #190390
Task-4128966
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr