[FW][FIX] mail: fix error when sending mail notifications with no author #194618
Conversation
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the `_is_internal` on it. When the author is `False`, the function generating the mail crashes as the `_is_internal` function is undefined on a boolean variable. To address this issue, we will ensure the existence of the author before invoking any methods defined in the `res.users` model. This solution prevents errors and ensures the email template functions correctly. see: odoo/odoo/odoo#190390 Task-4128966 X-original-commit: 954d710
|
|
|
@julien-banken @tde-banana-odoo cherrypicking of pull request #194569 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
|
@julien-banken @tde-banana-odoo this forward port of #194569 is awaiting action (not merged or closed). |
2 similar comments
|
@julien-banken @tde-banana-odoo this forward port of #194569 is awaiting action (not merged or closed). |
|
@julien-banken @tde-banana-odoo this forward port of #194569 is awaiting action (not merged or closed). |
|
Note: Fixed in the original PR FW #194439 |
xmo-odoo
deleted the
saas-18.1-18.0-mail-fix-error-when-sending-mail-notifications-with-no-author-jbn-Aw9y-fw
branch
4 participants
There are instances where an email notification may not have an associated author. In the mail notification template, we forgot to check that the author exists before calling the
_is_internalon it. When the author isFalse, the function generating the mail crashes as the_is_internalfunction is undefined on a boolean variable.To address this issue, we will ensure the existence of the author before invoking any methods defined in the
res.usersmodel. This solution prevents errors and ensures the email template functions correctly.see: #190390
Task-4128966
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #194569