Skip to content

Conversation

@fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Feb 10, 2025

This commit make brazilen fields always display in address
form even though b2b fields settings disabled from edition
because in LATAM country ID Type and ID Number field
are required for billing.

Also revert wrong fixed PR #194110

task-3628329

Forward-Port-Of: #196965
Forward-Port-Of: #196182

This commit make brazilen fields always display in address
form even though b2b fields settings disabled from edition
because in LATAM country `ID Type` and `ID Number` field
are required for billing.

task-3628329

X-original-commit: d5a5926
@robodoo
Copy link
Contributor

robodoo commented Feb 10, 2025

Pull request status dashboard

@fw-bot
Copy link
Contributor Author

fw-bot commented Feb 10, 2025

@kcv-odoo @clbr-odoo this PR targets master and is the last of the forward-port chain containing:

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Feb 10, 2025
@C3POdoo C3POdoo added the RD research & development, internal work label Feb 10, 2025
@kcv-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Feb 11, 2025
X-original-commit: e50dbfe
Part-of: #197219
Signed-off-by: Claire Bretton (clbr) <clbr@odoo.com>
Signed-off-by: Kartik Chavda (kcv) <kcv@odoo.com>
robodoo pushed a commit that referenced this pull request Feb 11, 2025
This commit make brazilen fields always display in address
form even though b2b fields settings disabled from edition
because in LATAM country `ID Type` and `ID Number` field
are required for billing.

task-3628329

closes #197219

X-original-commit: d5a5926
Signed-off-by: Claire Bretton (clbr) <clbr@odoo.com>
Signed-off-by: Kartik Chavda (kcv) <kcv@odoo.com>
@robodoo robodoo added the 18.2 label Feb 11, 2025
@robodoo robodoo closed this Feb 11, 2025
@fw-bot fw-bot deleted the master-17.0-l10n_br_website_sale-b2b-fields-kcv-415303-fw branch February 25, 2025 06:02
@chevalierv
Copy link
Contributor

Hello @kcv-odoo

This code is present in master (18.3) although you removed the parent method in #190312. I guess there was a mixup during the freeze as I know this PR had a bit of trouble to pass.

Can you check if it's really needed and remove it otherwise?

Have a nice day!

PS: same issue here: https://github.com/odoo/odoo/pull/202633/files#r2034961279

@kcv-odoo
Copy link
Contributor

kcv-odoo commented Apr 9, 2025

Hello @chevalierv

It seems there was some conflict with merger of PRs. We backported PR to saas-18.2 but I guess we only want to remove code in master as it is not causing any issue in saas-18.2. On it 🫡

Have a nice day!!

kcv-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 9, 2025
This commit remove unused code which was byproduct of
not proper rebased after merger of bugfix [1] and bad
forward-port of [2]

[1]: odoo#197219
[2]: odoo#202633
@kcv-odoo
Copy link
Contributor

kcv-odoo commented Apr 9, 2025

Here it is #205352

robodoo pushed a commit that referenced this pull request Apr 9, 2025
This commit remove unused code which was byproduct of
not proper rebased after merger of bugfix [1] and bad
forward-port of [2]

[1]: #197219
[2]: #202633

closes #205352

Signed-off-by: Valentin Chevalier <vcr@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

18.2 forwardport This PR was created by @fw-bot RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants