Skip to content

Conversation

@kcv-odoo
Copy link
Contributor

@kcv-odoo kcv-odoo commented Apr 9, 2025

This commit remove unused code which was byproduct of not proper rebased after merger of bugfix 1 and bad forward-port of 2

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

This commit remove unused code which was byproduct of
not proper rebased after merger of bugfix [1] and bad
forward-port of [2]

[1]: odoo#197219
[2]: odoo#202633
@robodoo
Copy link
Contributor

robodoo commented Apr 9, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team and Megaaaaaa and removed request for a team April 9, 2025 10:51
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 9, 2025
Copy link
Contributor

@chevalierv chevalierv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello

LGTM 👍

robodoo r+

Have a nice day!

@chevalierv
Copy link
Contributor

Thanks for the fix @kcv-odoo 🎉

robodoo pushed a commit that referenced this pull request Apr 9, 2025
This commit remove unused code which was byproduct of
not proper rebased after merger of bugfix [1] and bad
forward-port of [2]

[1]: #197219
[2]: #202633

closes #205352

Signed-off-by: Valentin Chevalier <vcr@odoo.com>
@robodoo robodoo added the 18.3 label Apr 9, 2025
@robodoo robodoo closed this Apr 9, 2025
@fw-bot fw-bot deleted the master-website_sale-remove-unused-code-kcv branch April 16, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

18.3 RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants