[FIX] core: prefetching of secondary new records #198124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
C3POdoo
requested review from
a team,
HydrionBurst and
xmo-odoo
and removed request for
a team
ryv-odoo
approved these changes
Feb 18, 2025
odoo/fields.py
Outdated
Comment on lines
+1203
to
+1206
There was a problem hiding this comment.
Suggested change
| for rec in recs: | |
| if rec._origin: | |
| value = self.convert_to_cache(rec._origin[self.name], rec, validate=False) | |
| env.cache.set(rec, self, value) | |
| for rec in recs: | |
| if (origin_rec := rec._origin): | |
| value = self.convert_to_cache(origin_rec[self.name], rec, validate=False) | |
| env.cache.set(rec, self, value) |
Maybe to avoid recreating rec._origin twice?
There was a problem hiding this comment.
Odoo 16 requires Python 3.7 minimum, and the walrus operator has been introduced in Python 3.8.
I will adapt this in forward-ports.
william-andre
approved these changes
Feb 18, 2025
HydrionBurst
approved these changes
Feb 18, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
rco-odoo
force-pushed
the
16.0-prefetch-new-lines-rco
branch
from
3e31c0b to
d2fac4f
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 18, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes #198124
Signed-off-by: Raphael Collet <rco@odoo.com>
This was referenced Feb 18, 2025
This was referenced Feb 20, 2025
gurneyalex
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Mar 26, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
gurneyalex
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Mar 31, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
gurneyalex
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Mar 31, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
gurneyalex
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Apr 3, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
gurneyalex
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Apr 3, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Apr 4, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Apr 14, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Apr 16, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jun 5, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jun 20, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jun 20, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Oct 9, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes odoo#198124
Signed-off-by: Raphael Collet <rco@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a recordset of new records, and a loop like
The implementation of
record.line_idsdoes not actually prefetch allrecords. It actually fetches the field on the records' origin (their corresponding real records), but only assigns the current new record in cache. As the prefetching relies on the cached values ofline_ids, the prefetching mechanism is actually broken online.The fix consists in assigning all the records to prefetch in this case. This does not add unexpected prefetching, since the origin records are prefetched as one batch anyway.