[FW][FIX] core: prefetching of secondary new records #198443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
X-original-commit: 7d14677
|
|
|
This PR targets saas-17.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Feb 20, 2025
Consider a recordset of new records, and a loop like
for record in records:
for line in record.line_ids:
line.value
The implementation of `record.line_ids` does not actually prefetch all
`records`. It actually fetches the field on the records' origin (their
corresponding real records), but only assigns the current new record in
cache. As the prefetching relies on the cached values of `line_ids`,
the prefetching mechanism is actually broken on `line`.
The fix consists in assigning all the records to prefetch in this case.
This does not add unexpected prefetching, since the origin records are
prefetched as one batch anyway.
closes #198443
X-original-commit: 7d14677
Signed-off-by: Raphael Collet <rco@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a recordset of new records, and a loop like
The implementation of
record.line_idsdoes not actually prefetch allrecords. It actually fetches the field on the records' origin (their corresponding real records), but only assigns the current new record in cache. As the prefetching relies on the cached values ofline_ids, the prefetching mechanism is actually broken online.The fix consists in assigning all the records to prefetch in this case. This does not add unexpected prefetching, since the origin records are prefetched as one batch anyway.
Forward-Port-Of: #198202
Forward-Port-Of: #198124