Skip to content

[FW][FIX] sale_timesheet : Prevent linking not-invoiced timesheet to invoice #209915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FW][FIX] sale_timesheet : Prevent linking not-invoiced timesheet to invoice #209915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions addons/sale_timesheet/models/account_move.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ def _link_timesheets_to_invoice(self, start_date=None, end_date=None):
"""
for line in self.filtered(lambda i: i.move_type == 'out_invoice' and i.state == 'draft').invoice_line_ids:
sale_line_delivery = line.sale_line_ids.filtered(lambda sol: sol.product_id.invoice_policy == 'delivery' and sol.product_id.service_type == 'timesheet')
if not start_date and not end_date:
start_date, end_date = self._get_range_dates(sale_line_delivery.order_id)
if sale_line_delivery:
domain = line._timesheet_domain_get_invoiced_lines(sale_line_delivery)
if start_date:
Expand All @@ -85,3 +87,8 @@ def _link_timesheets_to_invoice(self, start_date=None, end_date=None):
domain = expression.AND([domain, [('date', '<=', end_date)]])
timesheets = self.env['account.analytic.line'].sudo().search(domain)
timesheets.write({'timesheet_invoice_id': line.move_id.id})

def _get_range_dates(self, order):
# A method that can be overridden
# to set the start and end dates according to order values
return None, None