[IMP] website: allow parallax block overflow #218296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bvr-odoo
force-pushed
the
master-allow-parallax-children-overflow-bvr
branch
4 times, most recently
from
55f2501 to
5fd57f9
Compare
bvr-odoo
force-pushed
the
master-allow-parallax-children-overflow-bvr
branch
from
5fd57f9 to
91e96e2
Compare
qsm-odoo
requested changes
Jul 23, 2025
addons/website/static/src/builder/plugins/options/background_option.js
Outdated
Show resolved
Hide resolved
addons/website/static/src/builder/plugins/options/parallax_option_plugin.js
Outdated
Show resolved
Hide resolved
addons/website/static/src/builder/plugins/options/parallax_option_plugin.js
Outdated
Show resolved
Hide resolved
bvr-odoo
force-pushed
the
master-allow-parallax-children-overflow-bvr
branch
from
91e96e2 to
c45ff5d
Compare
qsm-odoo
requested changes
Jul 31, 2025
addons/website/static/src/builder/plugins/options/background_option.js
Outdated
Show resolved
Hide resolved
bvr-odoo
force-pushed
the
master-allow-parallax-children-overflow-bvr
branch
4 times, most recently
from
8b1c1f0 to
fbd6c72
Compare
|
@qsm-odoo I made the changes |
bvr-odoo
force-pushed
the
master-allow-parallax-children-overflow-bvr
branch
from
fbd6c72 to
ed39f42
Compare
bvr-odoo
force-pushed
the
master-allow-parallax-children-overflow-bvr
branch
from
ed39f42 to
fe329d3
Compare
I rebased both PRs onto 19.0 |
|
TODO: rebase on MASTER (too late for 19.0) |
bvr-odoo
force-pushed
the
master-allow-parallax-children-overflow-bvr
branch
from
fe329d3 to
bfb7c6b
Compare
bvr-odoo
force-pushed
the
master-allow-parallax-children-overflow-bvr
branch
from
bfb7c6b to
92f000f
Compare
qsm-odoo
requested changes
Oct 2, 2025
addons/html_builder/static/src/plugins/background_option/background_position_overlay.edit.scss
Outdated
Show resolved
Hide resolved
| @@ -34,7 +34,7 @@ export class BackgroundPositionOverlay extends Component { | |||
| // contains the background. Otherwise it's the section itself. | |||
| // And targetContainerEl should always be the section. | |||
| this.targetContainerEl = this.props.editingElement.classList.contains("s_parallax_bg") | |||
| ? this.props.editingElement.parentElement | |||
| ? this.props.editingElement.parentElement.parentElement | |||
There was a problem hiding this comment.
Yes, we do need it.
addons/website/static/src/builder/plugins/options/parallax_option_plugin.js
Outdated
Show resolved
Hide resolved
*: html_builder, html_editor, website_forum, website_slides This commit refactors the Parallax effect to fix overflow-related issues. Parallax backgrounds are now wrapped in an additional element with "overflow: hidden", instead of applying the "overflow: hidden" rule directly on the section. This prevents issues such as dropdowns or animations being cut off when inside a block with a parallax background. Steps to reproduce the issue: - Drag and drop a "Cover" block. - Drag and drop a "Search bar" inside the Cover block. - Save the page. - Type a letter in the "Search bar" so that the dropdown with search results overflows the bottom of the Cover block. - Bug: The dropdown is cut off, its bottom part is not visible. task-4926420
bvr-odoo
force-pushed
the
master-allow-parallax-children-overflow-bvr
branch
from
92f000f to
2085d95
Compare
qsm-odoo
approved these changes
Oct 6, 2025
robodoo
pushed a commit
that referenced
this pull request
Oct 6, 2025
*: html_builder, html_editor, website_forum, website_slides This commit refactors the Parallax effect to fix overflow-related issues. Parallax backgrounds are now wrapped in an additional element with "overflow: hidden", instead of applying the "overflow: hidden" rule directly on the section. This prevents issues such as dropdowns or animations being cut off when inside a block with a parallax background. Steps to reproduce the issue: - Drag and drop a "Cover" block. - Drag and drop a "Search bar" inside the Cover block. - Save the page. - Type a letter in the "Search bar" so that the dropdown with search results overflows the bottom of the Cover block. - Bug: The dropdown is cut off, its bottom part is not visible. task-4926420 closes #218296 Related: odoo/design-themes#1114 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo
pushed a commit
to odoo/design-themes
that referenced
this pull request
Oct 6, 2025
This commit adapts the themes to the new Parallax effect structure. We now wrap the parallax element in another element with "overflow: hidden" to avoid setting "overflow: hidden" on sections. That was causing elements like the dropdown of the search bar to be cut off and not fully visible. task-4926420 closes #1114 Related: odoo/odoo#218296 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the Parallax effect to fix overflow-related
issues. Parallax backgrounds are now wrapped in an additional element
with "overflow: hidden", instead of applying the "overflow: hidden" rule
directly on the section. This prevents issues such as dropdowns or
animations being cut off when inside a block with a parallax background.
Steps to reproduce the issue:
results overflows the bottom of the Cover block.
task-4926420