[FIX] web_editor: fix colorpicker UI update #234778
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the colorpicker UI would not update when switching to grayscale or transparent grayscale. The information of the color received to update the UI was expected to be a css value (hex). However for grayscale and transparent grayscale, the variable name was received instead of the value. Therefore, the colorpicker Ui would not be updated. It would therefore be difficult to make adjustments to these colors from the colorpicker UI. Steps to reproduce the issue: - Add a snippet - Change the background color to a custom color (the colorpicker interface was updated to match the color) - Change the background color to a grayscale color (the colorpicker interface was not updated to match the color) task-3806989 X-original-commit: 73f1585
Contributor
|
|
Contributor
Author
|
@romo-odoo @dery-odoo this PR targets saas-18.3 and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 7, 2025
Before this commit, the colorpicker UI would not update when switching to grayscale or transparent grayscale. The information of the color received to update the UI was expected to be a css value (hex). However for grayscale and transparent grayscale, the variable name was received instead of the value. Therefore, the colorpicker Ui would not be updated. It would therefore be difficult to make adjustments to these colors from the colorpicker UI. Steps to reproduce the issue: - Add a snippet - Change the background color to a custom color (the colorpicker interface was updated to match the color) - Change the background color to a grayscale color (the colorpicker interface was not updated to match the color) task-3806989 closes #234778 X-original-commit: 73f1585 Signed-off-by: Denis Rygaert <dery@odoo.com> Signed-off-by: Romaric Moyeuvre (romo) <romo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the colorpicker UI would not update when switching
to some colors (grayscale, transparent grayscale, theme colors). It
would therefore be difficult to make small changes to those colors.
This commit make the colorpicker update correctly.
Step to reproduce the bug (example with grayscale colors):
(the colorpicker interface was updated to match the color)
(the colorpicker interface was not updated to match the color)
task-3806989
Forward-Port-Of: #179883