Skip to content

Conversation

@seifgneedy
Copy link
Contributor

Enable Moroccan customers to add their ICE number(company_registry field) on portal through /my/account and on checkout on E-commerce.

task-4879950


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@seifgneedy seifgneedy requested a review from oco-odoo November 24, 2025 10:33
@robodoo
Copy link
Contributor

robodoo commented Nov 24, 2025

Pull request status dashboard

Enable Moroccan customers to add their ICE number(company_registry field) on
portal through /my/account and on checkout on E-commerce.

task-4879950
Instead of redefining the label to be ICE number in the views, use
invisible-add override to hide the field and re-add it with the correct
label.
@seifgneedy seifgneedy force-pushed the master-add-ice-address-segn branch from 37fe80c to 011c70d Compare November 27, 2025 14:47
Copy link
Contributor

@oco-odoo oco-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo
Copy link
Contributor

robodoo commented Dec 3, 2025

@seifgneedy @oco-odoo because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

@oco-odoo
Copy link
Contributor

oco-odoo commented Dec 3, 2025

@robodoo rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Dec 3, 2025

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Dec 3, 2025
Enable Moroccan customers to add their ICE number(company_registry field) on
portal through /my/account and on checkout on E-commerce.

task-4879950

Part-of: #237069
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
robodoo pushed a commit that referenced this pull request Dec 3, 2025
Instead of redefining the label to be ICE number in the views, use
invisible-add override to hide the field and re-add it with the correct
label.

closes #237069

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
@robodoo robodoo added the 19.1 label Dec 3, 2025
@robodoo robodoo closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants