Skip to content

Conversation

@fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Nov 25, 2025

task-4236158

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #211906

@robodoo
Copy link
Contributor

robodoo commented Nov 25, 2025

Pull request status dashboard

@fw-bot
Copy link
Contributor Author

fw-bot commented Nov 25, 2025

This PR targets saas-18.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Nov 25, 2025
@fw-bot
Copy link
Contributor Author

fw-bot commented Nov 25, 2025

@seifgneedy @oco-odoo ci/l10n failed on this forward-port PR

@seifgneedy seifgneedy force-pushed the saas-18.2-17.0-add-mr-localization-segn-479937-fw branch from 3468039 to 1fc2985 Compare November 26, 2025 16:07
@fw-bot
Copy link
Contributor Author

fw-bot commented Nov 26, 2025

@seifgneedy @oco-odoo this PR has become a normal PR because head updated from 3468039 to 1fc2985. It must be merged be forward-ported further.

@seifgneedy
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Nov 26, 2025

@seifgneedy you may want to rebuild or fix this PR as it has failed CI.

Copy link
Contributor

@dylankiss dylankiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look at the French translation file, and found some issues (didn't check the contents in the original PR).
@oco-odoo As a native speaker, I guess you can better assess whether my suggestions make sense.

@seifgneedy seifgneedy force-pushed the saas-18.2-17.0-add-mr-localization-segn-479937-fw branch from 1fc2985 to d82978b Compare November 27, 2025 09:19
Copy link
Contributor

@oco-odoo oco-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other French terms seem okay

@seifgneedy seifgneedy force-pushed the saas-18.2-17.0-add-mr-localization-segn-479937-fw branch from d82978b to 2749f90 Compare November 27, 2025 10:15
Copy link
Contributor

@dylankiss dylankiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me now translations-wise 😊
@robodoo override=ci/style
New l10n module in stable with translations

@seifgneedy
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 28, 2025
task-4236158

closes #237407

X-original-commit: 793c4c7
Related: odoo/enterprise#100520
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Seif Gneedy (segn) <segn@odoo.com>
robodoo pushed a commit that referenced this pull request Nov 28, 2025
task-4236158

closes #237407

X-original-commit: 793c4c7
Related: odoo/enterprise#100520
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Seif Gneedy (segn) <segn@odoo.com>
robodoo pushed a commit that referenced this pull request Nov 28, 2025
task-4236158

closes #237407

X-original-commit: 793c4c7
Related: odoo/enterprise#100520
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Seif Gneedy (segn) <segn@odoo.com>
robodoo pushed a commit that referenced this pull request Nov 28, 2025
task-4236158

closes #237407

X-original-commit: 793c4c7
Related: odoo/enterprise#100520
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Seif Gneedy (segn) <segn@odoo.com>
@robodoo robodoo closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forwardport This PR was created by @fw-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants