[18.0] [FIX] product: _compute_write_date when launched on product template NewId

[fw-bot]

If _compute_write_date is launched when creating a product.product without starting from an existing product.template, the compute may be launched before the product.template is created, hence record.product_tmpl_id.write_date is False, and comparing datetime and bool leads to an error.

This completes the fix proposed #138177

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #237523

[robodoo]

[fw-bot]

@marielejeune @Feyensv cherrypicking of pull request #237523 failed.

stdout:

Auto-merging addons/product/models/product_product.py
CONFLICT (content): Merge conflict in addons/product/models/product_product.py

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

[Feyensv]

I believe commit 7ba64a8 already handled the issue in 18.2 and next versions.

[marielejeune]

@Feyensv No this is not handled. Please check code in 18.2 and next versions. There were some modifications, hence the merge conflict, but the bug is not fixed.

[Feyensv]

Well, I believe the main (only?) case of template absence is when the product doesn't exist already (and therefore has no id, entering the if not record.id part).
I don't mind adding the fallback on now in the max if you say it's still an issue sometimes.

robodoo r+

[marielejeune]

@Feyensv indeed, thanks!