[FIX] stock_account: handle float quantities in fifo #238002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: - Storable product with fifo valuation & standard price of $1 - Do an inventory adjustment with 1.9 qty - Go to Inventory > Reporting > Stock and click on the total value Issue: Remaning quantity is 1 and remaining value is $1.00 A cast to int() on the `qty_available` was done so it would be used as a `limit` for a search. However, this meant that the decimal part of the quantity would be dropped. After further analysis, we changed the over-engineered limit to always be 100, as by nature that value is completely arbitrary anyway. opw-5230435 co-authored by: Robert Smith (rosm) <rosm@odoo.com> X-original-commit: f93859f
Contributor
|
|
Contributor
Author
|
@clesgow @amoyaux this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
Author
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 1, 2025
Steps to reproduce: - Storable product with fifo valuation & standard price of $1 - Do an inventory adjustment with 1.9 qty - Go to Inventory > Reporting > Stock and click on the total value Issue: Remaning quantity is 1 and remaining value is $1.00 A cast to int() on the `qty_available` was done so it would be used as a `limit` for a search. However, this meant that the decimal part of the quantity would be dropped. After further analysis, we changed the over-engineered limit to always be 100, as by nature that value is completely arbitrary anyway. opw-5230435 co-authored by: Robert Smith (rosm) <rosm@odoo.com> closes #238002 X-original-commit: f93859f Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com> Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Issue:
Remaning quantity is 1 and remaining value is $1.00
A cast to int() on the
qty_availablewas done so it would be used as alimitfor a search. However, this meant that the decimal part of the quantity would be dropped.After further analysis, we changed the over-engineered limit to always be 100, as by nature that value is completely arbitrary anyway.
opw-5230435
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #237802