[FIX] payment: fix processing of transaction issue #238530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps: - Install razorpay provider. - Set up provider and try to make payment with UPI PM. - Cancel processing payment in Razorpay form while processing keep form open. - Now complete that same tx in same Razorpay form. Issue: - Transaction stays in `error` state. Cause: - _process method skips calling _apply_changes for `error` stage transactions even though it should allowed. Fix: - Improve condition to only skip `_apply_changes` only if `_validate_amount` fails. issued PR: odoo#224627 Note: This is just temporary fix for the stable in master we will make `_validate_amount` method return boolean value depending on that we will decide whether to apply changes or not. X-original-commit: 1247a04
Contributor
|
|
Contributor
Author
|
@kcv-odoo @AntoineVDV this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 3, 2025
Steps: - Install razorpay provider. - Set up provider and try to make payment with UPI PM. - Cancel processing payment in Razorpay form while processing keep form open. - Now complete that same tx in same Razorpay form. Issue: - Transaction stays in `error` state. Cause: - _process method skips calling _apply_changes for `error` stage transactions even though it should allowed. Fix: - Improve condition to only skip `_apply_changes` only if `_validate_amount` fails. issued PR: #224627 Note: This is just temporary fix for the stable in master we will make `_validate_amount` method return boolean value depending on that we will decide whether to apply changes or not. closes #238530 X-original-commit: 1247a04 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Kartik Chavda (kcv) <kcv@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps:
Issue:
errorstate.Cause:
errorstage transactions even thoughit should allowed.
Fix:
_apply_changesonly if_validate_amountfails.issued PR: #224627
Note: This is just temporary fix for the stable in master we will make
_validate_amountmethodreturn boolean value depending on that we will decide whether to apply changes or not.
Forward-Port-Of: #238163