[FIX] website: Save cookie consent with primary button style#244875
Closed
[FIX] website: Save cookie consent with primary button style#244875
Conversation
Contributor
|
|
robodoo
added
forwardport
Contributor
Author
|
@sben-odoo @robinlej cherrypicking of pull request #243562 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Steps to reproduce: =================== 1. Enable the Cookies Bar in website settings. 2. Go to the website and enter Edit mode. 3. Select the Cookie Bar and change the button "I agree" style shape to "Default" (this applies the `.btn-primary` class). & Save 4. Accept the cookies & refresh -> The cookie bar appears again because the consent was not saved. Cause: ====== The `CookiesBar` widget inherits from the generic `Popup` widget. The `Popup` class defines a default behavior for elements with the `.btn-primary` class: clicking them triggers `onBtnPrimaryClick`, which closes the popup. By default, the cookie bar button uses `.btn-outline-primary`, avoiding this behavior. However, when the user changes the style to "Default", the button receives the `.btn-primary` class. Consequently, the parent `Popup` handler is triggered. It closes the modal prematurely, interrupting the `CookiesBar`'s specific logic (specifically `onAcceptClick`),So onHideModal won't be called inside the function, and as a result, the user's consent cookie is never written. Solution: ========= Override the event to avoid side effects on hide. opw-5484578 X-original-commit: dde9485
sben-odoo
force-pushed
the
19.0-19.0-opw-5484578-cookies_consent-sben-492336-fw
branch
from
dacc07b to
0e89112
Compare
Contributor
|
robodoo r+ |
Contributor
|
@robodoo r+ |
Contributor
|
This PR is already reviewed, reviewing it again is useless. |
This was referenced Jan 21, 2026
snrav-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 22, 2026
Steps to reproduce: =================== 1. Enable the Cookies Bar in website settings. 2. Go to the website and enter Edit mode. 3. Select the Cookie Bar and change the button "I agree" style shape to "Default" (this applies the `.btn-primary` class). & Save 4. Accept the cookies & refresh -> The cookie bar appears again because the consent was not saved. Cause: ====== The `CookiesBar` widget inherits from the generic `Popup` widget. The `Popup` class defines a default behavior for elements with the `.btn-primary` class: clicking them triggers `onBtnPrimaryClick`, which closes the popup. By default, the cookie bar button uses `.btn-outline-primary`, avoiding this behavior. However, when the user changes the style to "Default", the button receives the `.btn-primary` class. Consequently, the parent `Popup` handler is triggered. It closes the modal prematurely, interrupting the `CookiesBar`'s specific logic (specifically `onAcceptClick`),So onHideModal won't be called inside the function, and as a result, the user's consent cookie is never written. Solution: ========= Override the event to avoid side effects on hide. opw-5484578 closes odoo#244875 X-original-commit: dde9485 Signed-off-by: Robin Lejeune (role) <role@odoo.com> Signed-off-by: Saif Allah Ben Khalil (sben) <sben@odoo.com>
jlong1307
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 26, 2026
Steps to reproduce: =================== 1. Enable the Cookies Bar in website settings. 2. Go to the website and enter Edit mode. 3. Select the Cookie Bar and change the button "I agree" style shape to "Default" (this applies the `.btn-primary` class). & Save 4. Accept the cookies & refresh -> The cookie bar appears again because the consent was not saved. Cause: ====== The `CookiesBar` widget inherits from the generic `Popup` widget. The `Popup` class defines a default behavior for elements with the `.btn-primary` class: clicking them triggers `onBtnPrimaryClick`, which closes the popup. By default, the cookie bar button uses `.btn-outline-primary`, avoiding this behavior. However, when the user changes the style to "Default", the button receives the `.btn-primary` class. Consequently, the parent `Popup` handler is triggered. It closes the modal prematurely, interrupting the `CookiesBar`'s specific logic (specifically `onAcceptClick`),So onHideModal won't be called inside the function, and as a result, the user's consent cookie is never written. Solution: ========= Override the event to avoid side effects on hide. opw-5484578 closes odoo#244875 X-original-commit: dde9485 Signed-off-by: Robin Lejeune (role) <role@odoo.com> Signed-off-by: Saif Allah Ben Khalil (sben) <sben@odoo.com>
KazuakiWatanabe
pushed a commit
to KazuakiWatanabe/odoo_local
that referenced
this pull request
Jan 27, 2026
Steps to reproduce: =================== 1. Enable the Cookies Bar in website settings. 2. Go to the website and enter Edit mode. 3. Select the Cookie Bar and change the button "I agree" style shape to "Default" (this applies the `.btn-primary` class). & Save 4. Accept the cookies & refresh -> The cookie bar appears again because the consent was not saved. Cause: ====== The `CookiesBar` widget inherits from the generic `Popup` widget. The `Popup` class defines a default behavior for elements with the `.btn-primary` class: clicking them triggers `onBtnPrimaryClick`, which closes the popup. By default, the cookie bar button uses `.btn-outline-primary`, avoiding this behavior. However, when the user changes the style to "Default", the button receives the `.btn-primary` class. Consequently, the parent `Popup` handler is triggered. It closes the modal prematurely, interrupting the `CookiesBar`'s specific logic (specifically `onAcceptClick`),So onHideModal won't be called inside the function, and as a result, the user's consent cookie is never written. Solution: ========= Override the event to avoid side effects on hide. opw-5484578 closes odoo#244875 X-original-commit: dde9485 Signed-off-by: Robin Lejeune (role) <role@odoo.com> Signed-off-by: Saif Allah Ben Khalil (sben) <sben@odoo.com>
fw-bot
deleted the
19.0-19.0-opw-5484578-cookies_consent-sben-492336-fw
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
.btn-primaryclass). & Save-> The cookie bar appears again because the consent was not saved.
Cause:
The
CookiesBarwidget inherits from the genericPopupwidget. ThePopupclass defines a default behavior for elements with the.btn-primaryclass: clicking them triggersonBtnPrimaryClick, which closes the popup.By default, the cookie bar button uses
.btn-outline-primary, avoiding this behavior. However, when the user changes the style to "Default", the button receives the.btn-primaryclass. Consequently, the parentPopuphandler is triggered. It closes the modal prematurely, interrupting theCookiesBar's specific logic (specificallyonAcceptClick),So onHideModal won't be called inside the function, and as a result, the user's consent cookie is never written.Solution:
Override the event to avoid side effects on hide.
opw-5484578
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #243562