[FIX] base: default value in set_multi#25457
Merged
Conversation
Make sure to test `None` instead of any falsy value. Indeed, when we want to explicitly pass a `False` default value, `set_multi` might select an incorrect default value. This is for example the case of `_inverse_product_pricelist`, where `default_for_country` might be `False` on purpose. opw-1858271
nim-odoo
force-pushed
the
10.0-opw-1858271-default_value-nim
branch
from
10f76c4 to
697b2f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to test
Noneinstead of any falsy value. Indeed, when wewant to explicitly pass a
Falsedefault value,set_multimightselect an incorrect default value.
This is for example the case of
_inverse_product_pricelist, wheredefault_for_countrymight beFalseon purpose.opw-1858271
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr