[FIX] hr_holidays: Fix domain of _get_leaves_from_vals#261963
Closed
jugj-odoo wants to merge 1 commit intoodoo:saas-19.2from
Closed
[FIX] hr_holidays: Fix domain of _get_leaves_from_vals#261963jugj-odoo wants to merge 1 commit intoodoo:saas-19.2from
jugj-odoo wants to merge 1 commit intoodoo:saas-19.2from
Conversation
Contributor
|
|
Currently if we have 2 versions on the same contract dates, we check leaves from the contract_start_date, instead of the version date. Meaning if we only have versions on 1 contract date, we will recalculate ALL the leaves all the time. This should not be the case.
jugj-odoo
force-pushed
the
saas-19.2-hr-holidays-fix-get-leaves-domain-jugj
branch
from
6db8296 to
3a80e00
Compare
Collaborator
|
@robodoo r+ |
Contributor
|
@jugj-odoo @pimodoo 'ci/l10n' failed on this reviewed PR. |
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2026
Currently if we have 2 versions on the same contract dates, we check leaves from the contract_start_date, instead of the version date. Meaning if we only have versions on 1 contract date, we will recalculate ALL the leaves all the time. This should not be the case. closes #261963 Signed-off-by: Pierre Masereel (pim) <pim@odoo.com>
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if we have 2 versions on the same contract dates, we check leaves from the contract_start_date, instead of the version date. Meaning if we only have versions on 1 contract date, we will recalculate ALL the leaves all the time. This should not be the case.