[FIX] web: fix colorpicker "unknown CORS error" on safari#64244
Closed
sdegueldre wants to merge 1 commit intoodoo:14.0from
Closed
[FIX] web: fix colorpicker "unknown CORS error" on safari#64244sdegueldre wants to merge 1 commit intoodoo:14.0from
sdegueldre wants to merge 1 commit intoodoo:14.0from
Conversation
Contributor
|
|
qsm-odoo
requested changes
Jan 11, 2021
Previously, when opening a colorpicker in safari, the crash manager would open with the message "An unknown CORS error occured [...]". This is actually odoo's default message when an error has no file, line or column, which is usually the case for security reasons on CORS error. This is however not a true CORS error, but a "ResizeObserver loop completed with undelivered notifications" error, which also does not report file, line and col for the error. This error is caused by the fact that in webkit, the baseline of an empty input is considered to be at the bottom of the input element, rather than at the baseline of the text of the input once it has some content. (see https://bugs.webkit.org/show_bug.cgi?id=142968 ) In the case of the colorpicker, it uses a ResizeObserver to update its UI, including updating the content of its inputs. This will cause the first _updateUI to fill the empty inputs, which changes the layout of the widget content and changes its size. Changing the size of an element inside of a handler of a ResizeObserver on that same element will cause an error and not call the callback again, so as to prevent infinite loop. This commit fixes that by filling the inputs before attaching the ResizeObserver, so that it has its final size from the get-go, and _updateUI will no longer change the layout/size, causing this error. opw-2419296
sdegueldre
force-pushed
the
14.0-web-colorpicker-unknown-cors-error-safari-fix-sad
branch
from
179aab0 to
10d118c
Compare
qsm-odoo
approved these changes
Jan 12, 2021
This was referenced Jan 12, 2021
qsm-odoo
deleted the
14.0-web-colorpicker-unknown-cors-error-safari-fix-sad
branch
fmdl
pushed a commit
to fmdl/odoo
that referenced
this pull request
Apr 29, 2021
Previously, when opening a colorpicker in safari, the crash manager would open with the message "An unknown CORS error occured [...]". This is actually odoo's default message when an error has no file, line or column, which is usually the case for security reasons on CORS error. This is however not a true CORS error, but a "ResizeObserver loop completed with undelivered notifications" error, which also does not report file, line and col for the error. This error is caused by the fact that in webkit, the baseline of an empty input is considered to be at the bottom of the input element, rather than at the baseline of the text of the input once it has some content. (see https://bugs.webkit.org/show_bug.cgi?id=142968 ) In the case of the colorpicker, it uses a ResizeObserver to update its UI, including updating the content of its inputs. This will cause the first _updateUI to fill the empty inputs, which changes the layout of the widget content and changes its size. Changing the size of an element inside of a handler of a ResizeObserver on that same element will cause an error and not call the callback again, so as to prevent infinite loop. This commit fixes that by filling the inputs before attaching the ResizeObserver, so that it has its final size from the get-go, and _updateUI will no longer change the layout/size, causing this error. opw-2419296 closes odoo#64244 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when opening a colorpicker in safari, the crash manager
would open with the message "An unknown CORS error occured [...]". This
is actually odoo's default message when an error has no file, line or
column, which is usually the case for security reasons on CORS error.
This is however not a true CORS error, but a "ResizeObserver loop
completed with undelivered notifications" error, which also does not
report file, line and col for the error.
This error is caused by the fact that in webkit, the baseline of an
empty input is considered to be at the bottom of the input element,
rather than at the baseline of the text of the input once it has some
content. (see https://bugs.webkit.org/show_bug.cgi?id=142968 )
In the case of the colorpicker, it uses a ResizeObserver to update its
UI, including updating the content of its inputs. This will cause the
first _updateUI to fill the empty inputs, which changes the layout of
the widget content and changes its size. Changing the size of an element
inside of a handler of a ResizeObserver on that same element will cause
an error and not call the callback again, so as to prevent infinite
loop.
This commit fixes that by filling the inputs before attaching the
ResizeObserver, so that it has its final size from the get-go, and
_updateUI will no longer change the layout/size, causing this error.
opw-2419296