fix(automated-curation): ISSUE-83 skipClassifiedElements empty-string bug - #336
Merged
dwolfson merged 1 commit intoSep 2, 2026
Merged
Conversation
… bug get_technology_type_elements(get_templates=True) built skipClassifiedElements as [skip_templates] where skip_templates was "" when get_templates=True -- sending a one-element list containing an empty string, not an empty list. Egeria correctly rejects the empty classification name (OMAG-COMMON-400-018 "The type name ... is not recognized"), so every call with get_templates=True fails outright. Found via a user report: a known live RelationalDatabase asset didn't appear browsing Technology Types -> Postgres Relational Databases in egeria-workspaces' Tech Catalog, even though it was directly retrievable by GUID and correctly tagged (deployedImplementationType: "PostgreSQL Relational Database"). The failure is masked downstream -- egeria-workspaces' tech_catalog_handler.py calls this with get_templates=True unconditionally and treats any "400" in the error message as "no elements found," so the whole listing silently renders empty instead of erroring. Fix: skip_classified_elements = [] if get_templates else ["Template"]. Also corrected the method's docstring sample body, which showed the same [""] value as if it were correct usage. Live-verified end-to-end, not just unit-tested: live-patched into quickstart-pyegeria-web's installed pyegeria (docker cp + restart, diff-confirmed), then curled the actual production route -- it now returns the previously-missing asset correctly (15 items with templates included vs. 14 without, consistent). Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Member
Author
|
Superseded — cherry-picked this fix directly onto |
dwolfson
added a commit
to dwolfson/egeria-python
that referenced
this pull request
Sep 2, 2026
…#336 superseded Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Member
Author
|
Correction — I closed this in error saying it was superseded by a merge to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_technology_type_elements(get_templates=True)builtskipClassifiedElementsas[skip_templates]whereskip_templateswas""whenget_templates=True— sending a one-element list containing an empty string, not an empty list. Egeria correctly rejects the empty classification name (OMAG-COMMON-400-018 "The type name ... is not recognized"), so every call withget_templates=Truefails outright.Found via a user report: a known live
RelationalDatabaseasset didn't appear browsing Technology Types → Postgres Relational Databases inegeria-workspaces' Tech Catalog, even though it was directly retrievable by GUID and correctly tagged (deployedImplementationType: "PostgreSQL Relational Database"). The failure is masked downstream —egeria-workspaces'tech_catalog_handler.pycalls this withget_templates=Trueunconditionally and treats any"400"in the error message as "no elements found," so the whole listing silently renders empty instead of erroring.Fix:
skip_classified_elements = [] if get_templates else ["Template"]. Also corrected the method's docstring sample body, which showed the same[""]value as if it were correct usage.Tracked as
egeria-pythonISSUE-83 inPYEGERIA_ISSUES.md.Testing
Live-verified end-to-end, not just unit-tested: live-patched into
quickstart-pyegeria-web's installed pyegeria (docker cp+ restart, diff-confirmed), then curled the actual production route — it now returns the previously-missing asset correctly (15 items with templates included vs. 14 without, consistent).🤖 Generated with Claude Code