fix: #108 card is not encapsulated in shadowRoot causing card mod styles to collide - #111
Merged
Merged
Conversation
regevbr
changed the title
Contributor
Author
|
@ofekashery can you please CR? |
Contributor
Author
|
@ofekashery can you please CR? |
1 similar comment
Contributor
Author
|
@ofekashery can you please CR? |
ofekashery
approved these changes
Oct 26, 2021
Owner
|
Thank you, @regevbr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #108
This PR encapsulated the created card in side a shadowRoot. This is required when using card-mod to add custom styles to the card, which adds a
<style>element that, if not inside a shadowRoot, will affect the entire view.@ofekashery can you please CR?
i.e
I'm already using the fix on my hassio instance and it works great