Default daemon shorthand hosts to localhost#1048
Merged
Merged
Conversation
4 tasks
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Adds an audit for task #1048 quantifying the path-storage portion of the 100K-files RSS gap (87.5 vs 7.4 MB at v0.5; 42.6 vs 7.9 MB current per the flist-memory baseline). Per-entry breakdown of `name: PathBuf` (24 B inline + heap with capacity slack) and `dirname: Arc<Path>` (16 B inline + 16 B `ArcInner` header), comparison to upstream's pool-allocated `struct file_struct` + `lastdir` cache from `flist.c`/`rsync.h`, and a test/benchmark plan reusing the existing file-entry memory benchmark. Recommends an `Arc<[u8]>` per-flist arena with `(offset, len)` slice fields as the natural shape for #1050, with `Box<[u8]>` post-sort as the smaller mechanical fallback.
This was referenced May 7, 2026
oferchen
added a commit
that referenced
this pull request
May 7, 2026
Audit per-entry path overhead in FileEntry vs upstream's pool-allocated file_struct, quantify the RSS gap at 100K entries, and propose five reduction strategies (Box<Path>, basename arena, packed extras, basename interning, bump allocator) with implementation cost and recommended sequencing. Closes task #1048.
1 task
oferchen
added a commit
that referenced
this pull request
May 7, 2026
1 task
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Adds an audit for task #1048 quantifying the path-storage portion of the 100K-files RSS gap (87.5 vs 7.4 MB at v0.5; 42.6 vs 7.9 MB current per the flist-memory baseline). Per-entry breakdown of `name: PathBuf` (24 B inline + heap with capacity slack) and `dirname: Arc<Path>` (16 B inline + 16 B `ArcInner` header), comparison to upstream's pool-allocated `struct file_struct` + `lastdir` cache from `flist.c`/`rsync.h`, and a test/benchmark plan reusing the existing file-entry memory benchmark. Recommends an `Arc<[u8]>` per-flist arena with `(offset, len)` slice fields as the natural shape for #1050, with `Box<[u8]>` post-sort as the smaller mechanical fallback.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Audit per-entry path overhead in FileEntry vs upstream's pool-allocated file_struct, quantify the RSS gap at 100K entries, and propose five reduction strategies (Box<Path>, basename arena, packed extras, basename interning, bump allocator) with implementation cost and recommended sequencing. Closes task #1048.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localhostwhen the host component is omitteduser@::and keep the provided identity::shorthand to prevent regressionsTesting
https://chatgpt.com/codex/tasks/task_e_68fbaf65d1b0832380329357946c37f8