docs(audits): Vec<FileEntry> vs upstream pool allocator (#1050)#3939
Merged
Conversation
Static audit comparing upstream rsync's per-flist slab pool (`lib/pool_alloc.c`) against oc-rsync's `Vec<FileEntry>` plus per-entry `PathBuf` and `Box<FileEntryExtras>` heap allocations. Lists bumpalo / typed-arena candidates for collapsing the file list into a single slab and the lifetime, Drop, and signal-cleanup risks that gate the pilot.
github-actions
Bot
added
the
documentation
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Static audit comparing upstream rsync's per-flist slab pool (`lib/pool_alloc.c`) against oc-rsync's `Vec<FileEntry>` plus per-entry `PathBuf` and `Box<FileEntryExtras>` heap allocations. Lists bumpalo / typed-arena candidates for collapsing the file list into a single slab and the lifetime, Drop, and signal-cleanup risks that gate the pilot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/pool_alloc.cslabs (one allocation perfile_structplus extras) against oc-rsync'sVec<FileEntry>with per-entryPathBufandBox<FileEntryExtras>heap chunks (~200 B + 3-4 mallocs each).bumpaloandtyped-arenaas the viable single-slab candidates, with notes on Drop avoidance, basename slicing, andArc<Path>dirname interning.engine/transfer/cli,Dropsemantics forFileEntryExtrasbuffers, signal-cancel cleanup, and INC_RECURSE segment sharing.Test plan