Handle extended ASCII whitespace in remote shell parser#1297
Merged
Conversation
This was referenced May 5, 2026
oferchen
added a commit
that referenced
this pull request
May 7, 2026
Specifies the criterion harness that gates the sharded BufferPool layout from #1295: 1/4/16/64 thread acquire-release loops with mixed adaptive buffer sizes, pass/fail thresholds keyed to linear scaling through 16 threads, and explicit risk mitigations for false sharing and hot-shard imbalance.
3 tasks
oferchen
added a commit
that referenced
this pull request
May 16, 2026
Add criterion microbench under crates/transfer/benches profiling four result-collection strategies (shared Arc<Mutex<Vec>>, sharded Mutex<Vec> by rayon worker id, crossbeam SegQueue, crossbeam unbounded channel) over 100K items at 1/4/8/16 rayon worker counts. Throughput is reported in elements/sec so the bench output names the worker count at which the single shared mutex saturates. The shipping parallel-stat path in crates/transfer/src/parallel_io.rs does not use Arc<Mutex<Vec>>; it collects via into_par_iter().map(f).collect(), which delegates to rayon's lock-free reducer. Document this in docs/audits/parallel-stat-collection.md and keep the microbench as the baseline against which any future PR that proposes reintroducing a shared mutex on this path must be measured (tracked under #1192, #1271, #1297, #1370, #1682).
oferchen
added a commit
that referenced
this pull request
May 16, 2026
… (#4170) * chore(bench): add parallel-stat collector contention microbench Add criterion microbench under crates/transfer/benches profiling four result-collection strategies (shared Arc<Mutex<Vec>>, sharded Mutex<Vec> by rayon worker id, crossbeam SegQueue, crossbeam unbounded channel) over 100K items at 1/4/8/16 rayon worker counts. Throughput is reported in elements/sec so the bench output names the worker count at which the single shared mutex saturates. The shipping parallel-stat path in crates/transfer/src/parallel_io.rs does not use Arc<Mutex<Vec>>; it collects via into_par_iter().map(f).collect(), which delegates to rayon's lock-free reducer. Document this in docs/audits/parallel-stat-collection.md and keep the microbench as the baseline against which any future PR that proposes reintroducing a shared mutex on this path must be measured (tracked under #1192, #1271, #1297, #1370, #1682). * chore: sync Cargo.lock after dev-dep addition
2 tasks
oferchen
added a commit
that referenced
this pull request
May 16, 2026
The #1297 task assumed a Mutex<Vec<Vec<u8>>> baseline for a single-mutex vs sharded contention bench. The production BufferPool already uses a thread-local single-slot cache in front of a lock-free crossbeam_queue::ArrayQueue with a CAS-admission soft cap. This audit documents the current architecture, lists the remaining (non-storage) mutexes, explains why the originally-scoped comparison cannot be authored, and records what is already measured vs the gaps that the sharded-queue follow-up plan would address.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Specifies the criterion harness that gates the sharded BufferPool layout from #1295: 1/4/16/64 thread acquire-release loops with mixed adaptive buffer sizes, pass/fail thresholds keyed to linear scaling through 16 threads, and explicit risk mitigations for false sharing and hot-shard imbalance.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
… (#4170) * chore(bench): add parallel-stat collector contention microbench Add criterion microbench under crates/transfer/benches profiling four result-collection strategies (shared Arc<Mutex<Vec>>, sharded Mutex<Vec> by rayon worker id, crossbeam SegQueue, crossbeam unbounded channel) over 100K items at 1/4/8/16 rayon worker counts. Throughput is reported in elements/sec so the bench output names the worker count at which the single shared mutex saturates. The shipping parallel-stat path in crates/transfer/src/parallel_io.rs does not use Arc<Mutex<Vec>>; it collects via into_par_iter().map(f).collect(), which delegates to rayon's lock-free reducer. Document this in docs/audits/parallel-stat-collection.md and keep the microbench as the baseline against which any future PR that proposes reintroducing a shared mutex on this path must be measured (tracked under #1192, #1271, #1297, #1370, #1682). * chore: sync Cargo.lock after dev-dep addition
oferchen
added a commit
that referenced
this pull request
May 18, 2026
The #1297 task assumed a Mutex<Vec<Vec<u8>>> baseline for a single-mutex vs sharded contention bench. The production BufferPool already uses a thread-local single-slot cache in front of a lock-free crossbeam_queue::ArrayQueue with a CAS-admission soft cap. This audit documents the current architecture, lists the remaining (non-storage) mutexes, explains why the originally-scoped comparison cannot be authored, and records what is already measured vs the gaps that the sharded-queue follow-up plan would address.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
… (#4170) * chore(bench): add parallel-stat collector contention microbench Add criterion microbench under crates/transfer/benches profiling four result-collection strategies (shared Arc<Mutex<Vec>>, sharded Mutex<Vec> by rayon worker id, crossbeam SegQueue, crossbeam unbounded channel) over 100K items at 1/4/8/16 rayon worker counts. Throughput is reported in elements/sec so the bench output names the worker count at which the single shared mutex saturates. The shipping parallel-stat path in crates/transfer/src/parallel_io.rs does not use Arc<Mutex<Vec>>; it collects via into_par_iter().map(f).collect(), which delegates to rayon's lock-free reducer. Document this in docs/audits/parallel-stat-collection.md and keep the microbench as the baseline against which any future PR that proposes reintroducing a shared mutex on this path must be measured (tracked under #1192, #1271, #1297, #1370, #1682). * chore: sync Cargo.lock after dev-dep addition
oferchen
added a commit
that referenced
this pull request
May 18, 2026
The #1297 task assumed a Mutex<Vec<Vec<u8>>> baseline for a single-mutex vs sharded contention bench. The production BufferPool already uses a thread-local single-slot cache in front of a lock-free crossbeam_queue::ArrayQueue with a CAS-admission soft cap. This audit documents the current architecture, lists the remaining (non-storage) mutexes, explains why the originally-scoped comparison cannot be authored, and records what is already measured vs the gaps that the sharded-queue follow-up plan would address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--rshTesting
https://chatgpt.com/codex/tasks/task_e_68ffd8be49a0832393e09ec429638762