Streamline CI and expose brand profiles#1386
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
325
to
+329
| with: | ||
| name: oc-rsync-packages | ||
| path: | | ||
| target/debian/*.deb | ||
| target/release/rpms/*.rpm | ||
| target/sbom/oc-rsync.cdx.json | ||
|
|
||
| target/${{ matrix.target }}/release/oc-rsync* | ||
| target/${{ matrix.target }}/release/oc-rsyncd* |
There was a problem hiding this comment.
The package-linux job is no longer a matrix job, yet the upload step still interpolates matrix.target to form the artifact paths. In GitHub Actions this expression is undefined in a non-matrix job, so the workflow will error out before artifacts are uploaded (“Unrecognized named-value: 'matrix'”) and the packages/SBOM are never published. Replace these expressions with concrete paths or add a matrix to the job before referencing matrix.*.
Useful? React with 👍 / 👎.
3 tasks
This was referenced May 7, 2026
oferchen
added a commit
that referenced
this pull request
May 7, 2026
3 tasks
oferchen
added a commit
that referenced
this pull request
May 17, 2026
#1386) (#4258) Adds platform_copy_gap, a single bench file that runs DefaultPlatformCopy on every host (FICLONE/copy_file_range on Linux, clonefile/fcopyfile on macOS, CopyFileExW/ReFS reflink on Windows) against std::fs::copy. Each host produces a platform_copy/std_baseline ratio per cell; the ratio is the kernel-fast-path win on that host and is the unit that can be compared across hosts. Records the chosen CopyMethod per cell on stderr so the Criterion report can be cross-referenced to the actual syscall. Cells: 4 KiB/64 KiB/1 MiB (100 files), 16 MiB (10 files), 256 MiB (2 files), sized so no cell exceeds ~30 s wall-clock on a typical CI runner. Independent of the kernel-async IOCP-vs-io_uring bench (#1868) which exercises a different syscall family.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
oferchen
added a commit
that referenced
this pull request
May 18, 2026
#1386) (#4258) Adds platform_copy_gap, a single bench file that runs DefaultPlatformCopy on every host (FICLONE/copy_file_range on Linux, clonefile/fcopyfile on macOS, CopyFileExW/ReFS reflink on Windows) against std::fs::copy. Each host produces a platform_copy/std_baseline ratio per cell; the ratio is the kernel-fast-path win on that host and is the unit that can be compared across hosts. Records the chosen CopyMethod per cell on stderr so the Criterion report can be cross-referenced to the actual syscall. Cells: 4 KiB/64 KiB/1 MiB (100 files), 16 MiB (10 files), 256 MiB (2 files), sized so no cell exceeds ~30 s wall-clock on a typical CI runner. Independent of the kernel-async IOCP-vs-io_uring bench (#1868) which exercises a different syscall family.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
#1386) (#4258) Adds platform_copy_gap, a single bench file that runs DefaultPlatformCopy on every host (FICLONE/copy_file_range on Linux, clonefile/fcopyfile on macOS, CopyFileExW/ReFS reflink on Windows) against std::fs::copy. Each host produces a platform_copy/std_baseline ratio per cell; the ratio is the kernel-fast-path win on that host and is the unit that can be compared across hosts. Records the chosen CopyMethod per cell on stderr so the Criterion report can be cross-referenced to the actual syscall. Cells: 4 KiB/64 KiB/1 MiB (100 files), 16 MiB (10 files), 256 MiB (2 files), sized so no cell exceeds ~30 s wall-clock on a typical CI runner. Independent of the kernel-async IOCP-vs-io_uring bench (#1868) which exercises a different syscall family.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_brand_profilehelper that returns the resolvedBrandProfileand document it with examplesTesting
https://chatgpt.com/codex/tasks/task_e_6900e2126e2083239d9311cf1ac4c1d2