Adjust CI coverage gate and extend cross-platform builds#1385
Merged
Conversation
3 tasks
This was referenced May 5, 2026
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Static, code-grounded audit of the fast_io fallback on macOS compared to the Linux io_uring path and the post-#1868 Windows IOCP path. Inventories every public copy/write/probe entry point with file:LINE, documents the inferred per-file syscall budget, identifies which io_uring features have no macOS analogue, and ranks the near-term mitigations (#1657 pwritev+F_NOCACHE, #1385 kqueue backend, macOS sendfile arm) by inferred payoff per unit of effort.
This was referenced May 7, 2026
oferchen
added a commit
that referenced
this pull request
May 7, 2026
Tight-scope design note for #1385: surveys current macOS I/O paths in fast_io, scopes the kqueue surface to vnode/socket/timer events, identifies disk-commit and daemon socket I/O as the candidate sites, contrasts kqueue's notification-only role with io_uring's submission plus completion model, and recommends kqueue (not dispatch_io) as the macOS implementation of the AsyncFileWriter trait from #1655.
4 tasks
4 tasks
oferchen
added a commit
that referenced
this pull request
May 17, 2026
Scaffold the kqueue-driven event loop described in docs/design/macos-kqueue-fast-io.md. Adds a safe wrapper over kqueue(2) and kevent(2) that consumers (disk-commit thread, daemon accept loop) will adopt in later PRs. - crates/fast_io/src/kqueue/mod.rs - macOS implementation backed by direct libc bindings (libc is already a unix workspace dep, the unsafe surface is two FFI calls). Supports EVFILT_READ / EVFILT_WRITE registration with edge-triggered EV_CLEAR semantics, a Duration-bounded wait(), and explicit EV_DELETE removal. - crates/fast_io/src/kqueue_stub.rs - cross-platform stub returning io::ErrorKind::Unsupported so callers compile on Linux / Windows without cfg branching. - Unit tests cover loop creation, pipe-driven read wakeup, timeout-empty behaviour, EOF signalling, and idempotent removal. No behavioural change for current callers; this lands the primitive so subsequent PRs can migrate the disk-commit backend onto it.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Static, code-grounded audit of the fast_io fallback on macOS compared to the Linux io_uring path and the post-#1868 Windows IOCP path. Inventories every public copy/write/probe entry point with file:LINE, documents the inferred per-file syscall budget, identifies which io_uring features have no macOS analogue, and ranks the near-term mitigations (#1657 pwritev+F_NOCACHE, #1385 kqueue backend, macOS sendfile arm) by inferred payoff per unit of effort.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Tight-scope design note for #1385: surveys current macOS I/O paths in fast_io, scopes the kqueue surface to vnode/socket/timer events, identifies disk-commit and daemon socket I/O as the candidate sites, contrasts kqueue's notification-only role with io_uring's submission plus completion model, and recommends kqueue (not dispatch_io) as the macOS implementation of the AsyncFileWriter trait from #1655.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Scaffold the kqueue-driven event loop described in docs/design/macos-kqueue-fast-io.md. Adds a safe wrapper over kqueue(2) and kevent(2) that consumers (disk-commit thread, daemon accept loop) will adopt in later PRs. - crates/fast_io/src/kqueue/mod.rs - macOS implementation backed by direct libc bindings (libc is already a unix workspace dep, the unsafe surface is two FFI calls). Supports EVFILT_READ / EVFILT_WRITE registration with edge-triggered EV_CLEAR semantics, a Duration-bounded wait(), and explicit EV_DELETE removal. - crates/fast_io/src/kqueue_stub.rs - cross-platform stub returning io::ErrorKind::Unsupported so callers compile on Linux / Windows without cfg branching. - Unit tests cover loop creation, pipe-driven read wakeup, timeout-empty behaviour, EOF signalling, and idempotent removal. No behavioural change for current callers; this lands the primitive so subsequent PRs can migrate the disk-commit backend onto it.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Scaffold the kqueue-driven event loop described in docs/design/macos-kqueue-fast-io.md. Adds a safe wrapper over kqueue(2) and kevent(2) that consumers (disk-commit thread, daemon accept loop) will adopt in later PRs. - crates/fast_io/src/kqueue/mod.rs - macOS implementation backed by direct libc bindings (libc is already a unix workspace dep, the unsafe surface is two FFI calls). Supports EVFILT_READ / EVFILT_WRITE registration with edge-triggered EV_CLEAR semantics, a Duration-bounded wait(), and explicit EV_DELETE removal. - crates/fast_io/src/kqueue_stub.rs - cross-platform stub returning io::ErrorKind::Unsupported so callers compile on Linux / Windows without cfg branching. - Unit tests cover loop creation, pipe-driven read wakeup, timeout-empty behaviour, EOF signalling, and idempotent removal. No behavioural change for current callers; this lands the primitive so subsequent PRs can migrate the disk-commit backend onto it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6900e2126e2083239d9311cf1ac4c1d2