Restrict CI testing to Linux and fix packaging artifacts#1389
Merged
Conversation
4 tasks
oferchen
added a commit
that referenced
this pull request
May 5, 2026
#3702) Design note for migrating the Windows ReFS reflink path off raw windows-sys onto the workspace-preferred windows-rs crate, with a runtime block-refcounting capability probe, chunked alignment handling, and a hook for the upcoming --cow / --no-cow CLI flag. Wire-protocol-neutral; replaces the existing PlatformCopy stub.
2 tasks
oferchen
added a commit
that referenced
this pull request
May 7, 2026
…1389) (#3905) Concise plan for the Windows reflink fast path: where the dispatch lives, the FSCTL_DUPLICATE_EXTENTS_TO_FILE call shape, ReFS detection with OnceLock caching, the fallback chain to CopyFileEx and std::fs::copy, alignment and source-handle risks, and the windows-rs binding policy keeping fast_io's public API safe.
oferchen
added a commit
that referenced
this pull request
May 13, 2026
…1389) (#3997) * feat(fast_io): add Windows ReFS reflink via FSCTL_DUPLICATE_EXTENTS (#1389) Add partial-file reflink support via FSCTL_DUPLICATE_EXTENTS_TO_FILE alongside the existing whole-file reflink. The new try_refs_reflink_range() accepts source offset, destination offset, and byte count, enabling block-level CoW clones of file subranges on ReFS. Extract compute_duplicate_extents_params() to encapsulate cluster alignment arithmetic, making parameter construction testable without requiring a ReFS volume. Nine pure-logic tests verify alignment for various cluster sizes (4KB, 64KB), boundary conditions, and edge cases. Platform-specific tests validate graceful fallback on NTFS (CI) and Unsupported on non-Windows. ReFS reflink added to platform_io_capabilities() output. * fix: gate ReFS reflink helpers with cfg(windows|test) and use div_ceil Add #[cfg(any(target_os = "windows", test))] to DuplicateExtentsParams and compute_duplicate_extents_params so they compile on all platforms for tests but don't trigger dead_code errors in production builds on Linux/macOS. Replace manual ((x + n - 1) / n) * n with .div_ceil(n).
This was referenced May 16, 2026
oferchen
added a commit
that referenced
this pull request
May 17, 2026
Annotate the design note to point at the existing implementation in fast_io::platform_copy and call out the windows-sys deviation from the original plan.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
#3702) Design note for migrating the Windows ReFS reflink path off raw windows-sys onto the workspace-preferred windows-rs crate, with a runtime block-refcounting capability probe, chunked alignment handling, and a hook for the upcoming --cow / --no-cow CLI flag. Wire-protocol-neutral; replaces the existing PlatformCopy stub.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…1389) (#3905) Concise plan for the Windows reflink fast path: where the dispatch lives, the FSCTL_DUPLICATE_EXTENTS_TO_FILE call shape, ReFS detection with OnceLock caching, the fallback chain to CopyFileEx and std::fs::copy, alignment and source-handle risks, and the windows-rs binding policy keeping fast_io's public API safe.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…1389) (#3997) * feat(fast_io): add Windows ReFS reflink via FSCTL_DUPLICATE_EXTENTS (#1389) Add partial-file reflink support via FSCTL_DUPLICATE_EXTENTS_TO_FILE alongside the existing whole-file reflink. The new try_refs_reflink_range() accepts source offset, destination offset, and byte count, enabling block-level CoW clones of file subranges on ReFS. Extract compute_duplicate_extents_params() to encapsulate cluster alignment arithmetic, making parameter construction testable without requiring a ReFS volume. Nine pure-logic tests verify alignment for various cluster sizes (4KB, 64KB), boundary conditions, and edge cases. Platform-specific tests validate graceful fallback on NTFS (CI) and Unsupported on non-Windows. ReFS reflink added to platform_io_capabilities() output. * fix: gate ReFS reflink helpers with cfg(windows|test) and use div_ceil Add #[cfg(any(target_os = "windows", test))] to DuplicateExtentsParams and compute_duplicate_extents_params so they compile on all platforms for tests but don't trigger dead_code errors in production builds on Linux/macOS. Replace manual ((x + n - 1) / n) * n with .div_ceil(n).
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Annotate the design note to point at the existing implementation in fast_io::platform_copy and call out the windows-sys deviation from the original plan.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Annotate the design note to point at the existing implementation in fast_io::platform_copy and call out the windows-sys deviation from the original plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6900e534279c832387ca93b36a6f890c