docs: mark Windows ReFS reflink (#1389) as implemented#4246
Merged
Conversation
Annotate the design note to point at the existing implementation in fast_io::platform_copy and call out the windows-sys deviation from the original plan.
github-actions
Bot
added
the
documentation
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Annotate the design note to point at the existing implementation in fast_io::platform_copy and call out the windows-sys deviation from the original plan.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Annotate the design note to point at the existing implementation in fast_io::platform_copy and call out the windows-sys deviation from the original plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/fast_io/src/platform_copy/dispatch.rs(try_refs_reflink_impl,try_refs_reflink_range_impl) and wired intoplatform_copy_implwith the ReFS -> CopyFileEx -> std::fs::copy fallback chain.crates/fast_io/src/refs_detect.rs::is_refs_filesystemwith per-volume memoization.CopyMethod::ReFsReflinkis enumerated and reported. Public re-exports live incrates/fast_io/src/lib.rs.crates/fast_io/src/platform_copy/tests.rscover non-Windows unsupported, NTFS graceful failure, missing source, ioctl parameter construction, and the partial-range variant.windows-sys0.61 (workspace convention) rather than the higher-levelwindowscrate suggested in the note. Allunsaferemains scoped to the ioctl wrappers with SAFETY comments.Test plan
crates/fast_io/src/platform_copy/tests.rscontinues to cover the ReFS reflink path.