Refactor client configuration into dedicated module#1642
Merged
Conversation
4 tasks
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…1637) (#3721) Audit current pool defaults (COPY_BUFFER_SIZE = 128 KiB, max_buffers = available_parallelism()), document the workloads they were tuned for, and call out where the defaults underprovision (1M-file parallel bursts) and overprovision (sequential single-threaded transfers, long-lived daemon mode). Cover the adaptive grow/shrink policy from #1638-#1641, the OC_RSYNC_BUFFER_POOL_SIZE and OC_RSYNC_BUFFER_POOL_STATS env vars from #1643, and the memory cap interaction from #1188. Close with sizing rules of thumb for operators and open questions for the pending #1642 benchmark.
4 tasks
oferchen
added a commit
that referenced
this pull request
May 7, 2026
Trim the audit to the five-section sizing brief: implementation overview, default capacity and per-buffer size with line refs, sizing assumptions (target concurrency, per-thread reuse, memory budget), trade-offs (smaller pool vs larger pool, shared singleton, resizer cadence), and five improvement proposals (workload-derived sizing, CLI flag for OC_RSYNC_BUFFER_POOL_SIZE per #1643, instrumentation hooks, idle drain, memory-cap-aware adaptive ceiling). Drops the verbose history, recommendations, and pending-benchmark questions that belong in #1642 follow-up notes.
3 tasks
oferchen
added a commit
that referenced
this pull request
May 17, 2026
…4254) Adds a single-threaded Criterion benchmark that contrasts the fixed-size BufferPool against the PID-controller-driven adaptive pool from buffer_controller.rs across four workload shapes: - steady_uniform - 1000 acquires of 64 KiB constant. - bursty_small - alternating bursts of 100 x 4 KiB and 10 x 1 MiB. - growing - 100 acquires each at 16 KiB, 64 KiB, 256 KiB, 1 MiB. - shrinking - reverse of growing. The adaptive cell feeds record_transfer samples so the controller's PID recommendation evolves over the run, mirroring the production wiring in acquire_controlled_from. Companion to buffer_pool_contention.rs. Refs #1642
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…1637) (#3721) Audit current pool defaults (COPY_BUFFER_SIZE = 128 KiB, max_buffers = available_parallelism()), document the workloads they were tuned for, and call out where the defaults underprovision (1M-file parallel bursts) and overprovision (sequential single-threaded transfers, long-lived daemon mode). Cover the adaptive grow/shrink policy from #1638-#1641, the OC_RSYNC_BUFFER_POOL_SIZE and OC_RSYNC_BUFFER_POOL_STATS env vars from #1643, and the memory cap interaction from #1188. Close with sizing rules of thumb for operators and open questions for the pending #1642 benchmark.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Trim the audit to the five-section sizing brief: implementation overview, default capacity and per-buffer size with line refs, sizing assumptions (target concurrency, per-thread reuse, memory budget), trade-offs (smaller pool vs larger pool, shared singleton, resizer cadence), and five improvement proposals (workload-derived sizing, CLI flag for OC_RSYNC_BUFFER_POOL_SIZE per #1643, instrumentation hooks, idle drain, memory-cap-aware adaptive ceiling). Drops the verbose history, recommendations, and pending-benchmark questions that belong in #1642 follow-up notes.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…4254) Adds a single-threaded Criterion benchmark that contrasts the fixed-size BufferPool against the PID-controller-driven adaptive pool from buffer_controller.rs across four workload shapes: - steady_uniform - 1000 acquires of 64 KiB constant. - bursty_small - alternating bursts of 100 x 4 KiB and 10 x 1 MiB. - growing - 100 acquires each at 16 KiB, 64 KiB, 256 KiB, 1 MiB. - shrinking - reverse of growing. The adaptive cell feeds record_transfer samples so the controller's PID recommendation evolves over the run, mirroring the production wiring in acquire_controlled_from. Companion to buffer_pool_contention.rs. Refs #1642
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…4254) Adds a single-threaded Criterion benchmark that contrasts the fixed-size BufferPool against the PID-controller-driven adaptive pool from buffer_controller.rs across four workload shapes: - steady_uniform - 1000 acquires of 64 KiB constant. - bursty_small - alternating bursts of 100 x 4 KiB and 10 x 1 MiB. - growing - 100 acquires each at 16 KiB, 64 KiB, 256 KiB, 1 MiB. - shrinking - reverse of growing. The adaptive cell feeds record_transfer samples so the controller's PID recommendation evolves over the run, mirroring the production wiring in acquire_controlled_from. Companion to buffer_pool_contention.rs. Refs #1642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client::configmodule that is re-exported for callersclient::modafter the extraction so it focuses on orchestration logic and re-exports the configuration APITesting
https://chatgpt.com/codex/tasks/task_e_6902d2e8d1848323869860e594378a0f