docs(audits): tighten BufferPool capacity sizing audit (#1637)#3865
Merged
Conversation
Trim the audit to the five-section sizing brief: implementation overview, default capacity and per-buffer size with line refs, sizing assumptions (target concurrency, per-thread reuse, memory budget), trade-offs (smaller pool vs larger pool, shared singleton, resizer cadence), and five improvement proposals (workload-derived sizing, CLI flag for OC_RSYNC_BUFFER_POOL_SIZE per #1643, instrumentation hooks, idle drain, memory-cap-aware adaptive ceiling). Drops the verbose history, recommendations, and pending-benchmark questions that belong in #1642 follow-up notes.
github-actions
Bot
added
the
documentation
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Trim the audit to the five-section sizing brief: implementation overview, default capacity and per-buffer size with line refs, sizing assumptions (target concurrency, per-thread reuse, memory budget), trade-offs (smaller pool vs larger pool, shared singleton, resizer cadence), and five improvement proposals (workload-derived sizing, CLI flag for OC_RSYNC_BUFFER_POOL_SIZE per #1643, instrumentation hooks, idle drain, memory-cap-aware adaptive ceiling). Drops the verbose history, recommendations, and pending-benchmark questions that belong in #1642 follow-up notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/audits/buffer-pool-capacity-sizing.mdaudit to the focused 5-section brief required by tracking issue Run cargo fmt on windows gnu unwinding shim #1637: implementation overview, default capacity and per-buffer size, sizing assumptions, trade-offs, and proposed improvements.OC_RSYNC_BUFFER_POOL_SIZEenv-var override per Refactor client configuration module #1643 in the proposed CLI flag improvement.Test plan
wc -l docs/audits/buffer-pool-capacity-sizing.mdis under 350.grep -ni "claude\|internal"returns no matches.grep "—"returns no em-dashes.crates/engine/src/local_copy/buffer_pool/module layout.