Enforce coverage thresholds in CI#1652
Merged
Merged
Conversation
6 tasks
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Static, code-grounded audit of the fast_io fallback on macOS compared to the Linux io_uring path and the post-#1868 Windows IOCP path. Inventories every public copy/write/probe entry point with file:LINE, documents the inferred per-file syscall budget, identifies which io_uring features have no macOS analogue, and ranks the near-term mitigations (#1657 pwritev+F_NOCACHE, #1385 kqueue backend, macOS sendfile arm) by inferred payoff per unit of effort.
2 tasks
oferchen
added a commit
that referenced
this pull request
May 7, 2026
) Document the macOS-specific code paths in crates/fast_io/src/, contrast them against the Linux io_uring/copy_file_range/sendfile fast paths, quantify the structural performance gap on small-file vs large-file workloads, point at where dispatch_io and kqueue would close it, and recommend cross-platform micro-benchmarks. Refs #1652.
2 tasks
oferchen
added a commit
that referenced
this pull request
May 7, 2026
3 tasks
oferchen
added a commit
that referenced
this pull request
May 13, 2026
Static, source-grounded audit of the macOS fallback chain in crates/fast_io/. Maps each Linux io_uring path to its macOS equivalent, identifies that MacosWriter (F_NOCACHE + writev) is implemented but unwired from the disk-commit dispatcher, and recommends a one-screen fix in disk_commit/process.rs to deliver the win.
3 tasks
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Static, code-grounded audit of the fast_io fallback on macOS compared to the Linux io_uring path and the post-#1868 Windows IOCP path. Inventories every public copy/write/probe entry point with file:LINE, documents the inferred per-file syscall budget, identifies which io_uring features have no macOS analogue, and ranks the near-term mitigations (#1657 pwritev+F_NOCACHE, #1385 kqueue backend, macOS sendfile arm) by inferred payoff per unit of effort.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
) Document the macOS-specific code paths in crates/fast_io/src/, contrast them against the Linux io_uring/copy_file_range/sendfile fast paths, quantify the structural performance gap on small-file vs large-file workloads, point at where dispatch_io and kqueue would close it, and recommend cross-platform micro-benchmarks. Refs #1652.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Static, source-grounded audit of the macOS fallback chain in crates/fast_io/. Maps each Linux io_uring path to its macOS equivalent, identifies that MacosWriter (F_NOCACHE + writev) is implemented but unwired from the disk-commit dispatcher, and recommends a one-screen fix in disk_commit/process.rs to deliver the win.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6902e135e73883238274dd3ad797474a