Add rust-toolchain manifest with required cross targets#1675
Merged
Conversation
3 tasks
oferchen
added a commit
that referenced
this pull request
Apr 29, 2026
…3437) Documentation-only audit of the daemon's accept-loop and per-connection threading model. Compares three paths (raw mio event loop, full tokio async accept, status quo thread-per-connection) against upstream rsync 3.4.1's select+fork model and against the existing async_session scaffold. Recommends extending the in-tree async path behind the existing async Cargo feature rather than introducing a new mio variant alongside the synchronous loop.
oferchen
added a commit
that referenced
this pull request
May 1, 2026
…3437) Documentation-only audit of the daemon's accept-loop and per-connection threading model. Compares three paths (raw mio event loop, full tokio async accept, status quo thread-per-connection) against upstream rsync 3.4.1's select+fork model and against the existing async_session scaffold. Recommends extending the in-tree async path behind the existing async Cargo feature rather than introducing a new mio variant alongside the synchronous loop.
3 tasks
oferchen
added a commit
that referenced
this pull request
May 1, 2026
Adds a docs-only RFC at docs/audits/async-daemon-listener.md proposing a feature-gated tokio-based async accept loop for the daemon. The design holds tokio at the accept boundary only and delegates per- session work to the existing synchronous handle_session via spawn_blocking, satisfying the workspace tokio dependency-scope policy. Complements the prior event-loop multiplexing audit (#1675) without superseding it. Phase 1 only - no implementation, no Cargo or Rust changes.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…3437) Documentation-only audit of the daemon's accept-loop and per-connection threading model. Compares three paths (raw mio event loop, full tokio async accept, status quo thread-per-connection) against upstream rsync 3.4.1's select+fork model and against the existing async_session scaffold. Recommends extending the in-tree async path behind the existing async Cargo feature rather than introducing a new mio variant alongside the synchronous loop.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Adds a docs-only RFC at docs/audits/async-daemon-listener.md proposing a feature-gated tokio-based async accept loop for the daemon. The design holds tokio at the accept boundary only and delegates per- session work to the existing synchronous handle_session via spawn_blocking, satisfying the workspace tokio dependency-scope policy. Complements the prior event-loop multiplexing audit (#1675) without superseding it. Phase 1 only - no implementation, no Cargo or Rust changes.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust-toolchain.tomlmanifest that pins Rust 1.87.0 for the workspaceTesting
https://chatgpt.com/codex/tasks/task_e_6903531638d08323a51ccb6eaa3a75f5