docs(daemon): RFC sketch for async tokio listener (#1934)#3505
Merged
Conversation
Adds a docs-only RFC at docs/audits/async-daemon-listener.md proposing a feature-gated tokio-based async accept loop for the daemon. The design holds tokio at the accept boundary only and delegates per- session work to the existing synchronous handle_session via spawn_blocking, satisfying the workspace tokio dependency-scope policy. Complements the prior event-loop multiplexing audit (#1675) without superseding it. Phase 1 only - no implementation, no Cargo or Rust changes.
github-actions
Bot
added
the
documentation
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Adds a docs-only RFC at docs/audits/async-daemon-listener.md proposing a feature-gated tokio-based async accept loop for the daemon. The design holds tokio at the accept boundary only and delegates per- session work to the existing synchronous handle_session via spawn_blocking, satisfying the workspace tokio dependency-scope policy. Complements the prior event-loop multiplexing audit (#1675) without superseding it. Phase 1 only - no implementation, no Cargo or Rust changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/audits/async-daemon-listener.md, a sketch-only RFC for task Accept quoted fallback override values #1934 proposing a feature-gated tokio-based async accept loop for the daemon.handle_sessionviatokio::task::spawn_blocking, keeping tokio strictly insidecrates/daemonper the workspace dependency-scope policy (Fix Windows PATHEXT parsing for fallback binary search #1818, Modularize CLI drive orchestration helpers #1779).docs/audits/daemon-event-loop-multiplexing.md(Add rust-toolchain manifest with required cross targets #1675) by narrowing its option (b) into a concrete, opt-inasync-daemonCargo feature gate. Phase 2 implementation lives in Normalize quoted fallback keywords #1935; benchmarking lives in Optimize rolling checksum bulk rolls #1933.Scope
Cargo.tomlchanges, no Rust changes, no feature flag added in this PR.master(seeLast verified: 2026-05-01marker in the doc).Test plan
master(crates/daemon/src/daemon/sections/server_runtime/{accept_loop,connection,listener}.rs,crates/daemon/src/daemon/async_session/{listener,mod}.rs,crates/daemon/src/daemon/sections/signals.rs,crates/daemon/src/systemd.rs,crates/daemon/Cargo.toml).spawn_blockingboundary is consistent with the project's tokio dependency-scope policy ininternal docs.